Skip to content

Subissue: Enable vtk ASCII output for ghost data #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holke opened this issue Mar 21, 2025 · 0 comments · May be fixed by #1493
Open

Subissue: Enable vtk ASCII output for ghost data #1492

holke opened this issue Mar 21, 2025 · 0 comments · May be fixed by #1493
Labels
priority:low Should be solved eventually workload:low Would take half a day or less

Comments

@holke
Copy link
Collaborator

holke commented Mar 21, 2025

ASCII sub-issue of #1487

Feature request

Currently if VTK output is called with the "write_ghosts" flag, then still "0" is written for any user data.
Instead, if "write_ghosts" is set and user data is provided, then the values at the ghost element indices should be written our correctly.

Is your feature request related to a problem? Please describe.
It is not properly documented that we do not write the ghost data which leads to misunderstanding of the function and wrong assumptions on the actual data present.

Describe the solution or feature you'd like
If "write_ghosts" is set in t8_forest_write_vtk_ext then any provided data must contain entries for ghost values and these should be written into the vtu file in ASCII mode.

Describe alternatives you've considered
Alternatively at leas a "nan" or "inf" value should be written instead of "0" in order to not confuse it with real data.

Estimated priority
Which of these is most applicable (remove the others):

"Priority: low" Should be solved eventually

Additional context
This came up during a debugging session with an applications and the users did not know that we do not write ghost values and were confused about 0 being written. They thought their code was not setting the ghost values correctly.

@holke holke changed the title Enable vtk ASCII output for ghost data Subissue: Enable vtk ASCII output for ghost data Mar 21, 2025
@ole-alb ole-alb added priority:low Should be solved eventually workload:low Would take half a day or less labels Apr 7, 2025
@t8ddy t8ddy moved this from In-Box to ToDo in t8code's Issue Landing page Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Should be solved eventually workload:low Would take half a day or less
Projects
Status: ToDo
Development

Successfully merging a pull request may close this issue.

2 participants