Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EDDP monitor into a BGS monitor #177

Open
Tkael opened this issue Oct 22, 2017 · 5 comments
Open

Update EDDP monitor into a BGS monitor #177

Tkael opened this issue Oct 22, 2017 · 5 comments
Labels
6. not up to spec The expected behaviour per the spec doesn’t match the observed behaviour. significant work Just sayin'

Comments

@Tkael
Copy link
Member

Tkael commented Oct 22, 2017

Observed

(Broken out from issue #97)
EDDI relies on data from http://api.eddp.co, which is not up to date. Faction arrays with active and pending states aren't transmitted or handled appropriately by the server or the client.

  • array data for faction active states, pending states, happiness, etc. are not handled by server,
  • server returns localized names rather than ednames. Wherever possible, ednames should be made available.

Investigation

Faction state changes are handled differently in that they are relayed more or less in real time from the EDDN TCP uplink. Though this is bounced through http://api.eddp.co, faction state changes should continue to remain relatively reliable. See https://github.com/EDSM-NET/EDDN/wiki for how this information is transmitted and EddpMonitor.cs for how EDDI receives the data.

http://api.eddp.co appears to be listening to 'FSDJump' and updating a database of faction states. When a faction state change is detected, the server fires off an update of its own for EDDI users to pick up. This update is currently a text string like

2018-02-10T22:11:55 EddpMonitor:monitor [D] Message is {"newstate":"None","oldstate":"Boom","systemname":"Alintun","x":-78.9375,"y":110.8125,"z":-36.0625} 

Cross reference with EDCD/EDDP-API#3.

@Tkael Tkael added this to the post-2.4.2 milestone Oct 22, 2017
@Tkael Tkael removed this from the post-2.4.2 milestone Jan 18, 2018
@Tkael Tkael changed the title EDDI Core: Switch endpoint for EDDP faction updates EDDI Core: Update endpoint for EDDP faction updates Jun 24, 2019
@Tkael
Copy link
Member Author

Tkael commented Jun 24, 2019

Also revise the monitor name to BGS monitor?

@Tkael Tkael changed the title EDDI Core: Update endpoint for EDDP faction updates EDDI Core: Update EDDP monitor - faction active states are not transmitted or received under the current implementation (only obsolete overall system faction changes for the controlling faction) Jun 24, 2019
@Tkael Tkael changed the title EDDI Core: Update EDDP monitor - faction active states are not transmitted or received under the current implementation (only obsolete overall system faction changes for the controlling faction) Update EDDP monitor - array data for faction active state, pending state, happiness, etc. are not handled Jul 16, 2019
@Tkael Tkael changed the title Update EDDP monitor - array data for faction active state, pending state, happiness, etc. are not handled Update EDDP monitor - array data for faction active states, pending states, happiness, etc. are not handled Jul 16, 2019
@Tkael Tkael changed the title Update EDDP monitor - array data for faction active states, pending states, happiness, etc. are not handled Update EDDP monitor - array data for faction active states, pending states, happiness, etc. are not handled, server returns localized names rather than ednames Sep 2, 2019
@Tkael Tkael changed the title Update EDDP monitor - array data for faction active states, pending states, happiness, etc. are not handled, server returns localized names rather than ednames Update EDDP monitor - array data for faction active states, pending states, happiness, etc. are not handled by server, server returns localized names rather than ednames Sep 2, 2019
@Tkael Tkael changed the title Update EDDP monitor - array data for faction active states, pending states, happiness, etc. are not handled by server, server returns localized names rather than ednames Update EDDP monitor and server - array data for faction active states, pending states, happiness, etc. are not handled by server, server returns localized names rather than ednames Sep 2, 2019
@Tkael Tkael changed the title Update EDDP monitor and server - array data for faction active states, pending states, happiness, etc. are not handled by server, server returns localized names rather than ednames Update EDDP monitor and server Sep 2, 2019
@Tkael
Copy link
Member Author

Tkael commented Sep 2, 2019

Notes:

  • For expansion, 75% will fire expansion regardless of whether the faction drops lower before pending is complete. People tend to use arbitrary warning point below 75%, since once 75% is reached expansion can no longer be prevented.
  • For retreat, the faction must be under 2.5% to trigger the pending state, again to trigger the active state, and yet again to complete the state 'successfully' by actually retreating.
  • Civil war/war is triggered by parity to other factions (when influence would cross each other in influence, they instead go to exact parity and go into the conflict process). Civil war is typically triggered if factions originate from the same social group, war is triggered if they do not.
    • Social:
      • opens black markets
      • elections with other Socials, wars with others
      • usual group for Democracy, Cooperative, Confederacy or Communist governments, and some Theocracy governments
    • Corporate:
      • closes black markets
      • elections with other Corporates, wars with others
      • usual group for Corporation government
    • Authoritarian:
      • closes black markets
      • elections with other Authoritarians, wars with others
      • usual group for Dictatorship, Patronage, Feudal or Prison Colony governments, and some Theocracy governments
    • Criminal:
      • opens black markets
      • offers wider range of illegal missions
      • never has elections, always war/civil war
      • usual group for Anarchy government
  • Coups: If a faction is not in control of a system, a coup war is triggered if they reach greater than 60% and either faction is not in cooldown.

@Tkael
Copy link
Member Author

Tkael commented Sep 2, 2019

  • Add Min and Max influence triggers to the EDDP monitor?
  • Allow users to set triggers for changes to both active and to pending faction states?

@Tkael Tkael added 6. not up to spec The expected behaviour per the spec doesn’t match the observed behaviour. and removed 10. work unit (user unaffected) labels Jan 7, 2020
@Tkael
Copy link
Member Author

Tkael commented Jan 7, 2020

Recategorized since the EDDP monitor is unfit for purpose until this is corrected.

@Tkael Tkael added the significant work Just sayin' label Feb 27, 2021
@Tkael
Copy link
Member Author

Tkael commented Apr 21, 2021

@Tkael Tkael changed the title Update EDDP monitor and server Update EDDP monitor into a BGS monitor Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6. not up to spec The expected behaviour per the spec doesn’t match the observed behaviour. significant work Just sayin'
Projects
None yet
Development

No branches or pull requests

1 participant