New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This condition is unnecessary？ #13

Open

hefeng6500 opened this issue Sep 26, 2021 · 1 comment

Contributor

hefeng6500 commented Sep 26, 2021

Learning-JavaScript-Data-Structures-and-Algorithms-Third-Edition/LearningJavaScriptDataStructuresandAlgorithmsThirdEdition_Code/src/js/data-structures/avl-tree.js

Line 135 in 520e02f

this.getBalanceFactor(node.left) === BalanceFactor.BALANCED ||

Dear loiane.

I think this line is unnecessary, when the node is balanced, it not need to be rotate. it will be cause error if rotate bananced node

Collaborator

loiane commented Oct 21, 2021

Thanks for the comment, could you please raise a PR for the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment