You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I use addNodeParams to add some params to the url of the hosting website, and this function not only update the url, but also reloads the whole iframe.
Expected result
visit the extension, you can see "Service Version" combobox. Select a version in it, the version should be updated to current url, which is working, but also the whole extension/iframe is reloaded when you select, which is unwanted. As a react app, my extension will rerender data in the page, but labels like "Service Version", "Quality Status" will remain unchanged.
Actual result
When selected a new version, the whole page blinks/reloads, while as a react app it should only rerender charts, tables, not the whole page.
Steps to reproduce
(See the expected result and actual result sections)
Troubleshooting
This unwanted reload behavior happens after I add a addNodeParams call to update the url. Looking at that function's implementation, I can see it essentially does a window.history.pushState, and a LuigiConfig.configChanged(). pushState should only change the url, but never reload the page, I suspect configChanged reloads the whole iframe.
The text was updated successfully, but these errors were encountered:
Description
I have an extension on hyperspace portal, which is a react app, plugged into the portal as an iframe, communicating with the portal using Luigi: https://portal.hyperspace.tools.sap/projects/sf-demo-ext/components/sf-demo-ext-ui/sf-ring-deployment
I use
addNodeParams
to add some params to the url of the hosting website, and this function not only update the url, but also reloads the whole iframe.Expected result
visit the extension, you can see "Service Version" combobox. Select a version in it, the version should be updated to current url, which is working, but also the whole extension/iframe is reloaded when you select, which is unwanted. As a react app, my extension will rerender data in the page, but labels like "Service Version", "Quality Status" will remain unchanged.
Actual result
When selected a new version, the whole page blinks/reloads, while as a react app it should only rerender charts, tables, not the whole page.
Steps to reproduce
(See the expected result and actual result sections)
Troubleshooting
This unwanted reload behavior happens after I add a
addNodeParams
call to update the url. Looking at that function's implementation, I can see it essentially does awindow.history.pushState
, and aLuigiConfig.configChanged()
.pushState
should only change the url, but never reload the page, I suspectconfigChanged
reloads the whole iframe.The text was updated successfully, but these errors were encountered: