-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that all notebooks run with the latest version of the code #802
Comments
Greetings @matteobachetti, |
Hello @matteobachetti , |
@kartikmandar spelling mistakes surely need to be fixed. Please try to reduce the changes to the bare minimum (e.g. do not re-run full notebooks for changes to the Markdown text) |
Sure @matteobachetti I will keep that in mind. |
Hello @matteobachetti I checked all the notebooks extensively and apart from the issues AnonymousCodes911 and I solved, everything was working fine. Also there still some warning messages to solve in LombScargle notebook and some issues in Pulsar notebook. |
Hello @matteobachetti I checked Pulsar notebook and in requirements was missing seaborn library. Also in interactive phaseogram reset button wasn't working due to set_xdata function expects array as parameter. I raised a PR https://github.com/StingraySoftware/notebooks/pull/116 and another one to solve an error of dividing by 0 https://github.com/StingraySoftware/stingray/pull/907 |
As the title says.
The text was updated successfully, but these errors were encountered: