Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Role Layering Menu #1700

Open
1 of 3 tasks
Histalek opened this issue Dec 29, 2024 · 3 comments · Fixed by #1715
Open
1 of 3 tasks

Improve Role Layering Menu #1700

Histalek opened this issue Dec 29, 2024 · 3 comments · Fixed by #1715
Assignees

Comments

@Histalek
Copy link
Member

Histalek commented Dec 29, 2024

Is your feature request related to a problem? Please describe.

There are currently at least 2 pain points with the role layering menu:

  • each baserole that has less than 2 subroles installed doesn't have its subrole-layering section displayed leading to confusion when switching between different servers/collections
  • disabled subroles still show up the same as enabled ones do, which makes it harder to understand what the rolelayering will do
  • (does the order of subroles in a layer even have any effect? being allowed to manually order items in a layer gives the impression that the order matters)

Describe the solution you'd like

  • Show a notice why subrolelayering is not possible for each installed Baserole instead of hiding the whole section with less than 2 subroles installed
  • visually distinct roleicons for disable subroles, maybe grayscale the color (subroles are sorted into their baseclasses section here, so the color isn't as important here anyways)
  • (if the order inside a layer has no effect: disable manual ordering inside of a layer and autosort by roleid or rolename)
@TimGoll
Copy link
Member

TimGoll commented Jan 2, 2025

(does the order of subroles in a layer even have any effect? being allowed to manually order items in a layer gives the impression that the order matters)

That should not have any effect. At least in the layers. I'm not 100% sure about the unlayered sections, but I'm pretty sure it is the same

@Histalek Histalek added this to the Feature Backlog milestone Jan 8, 2025
@TimGoll
Copy link
Member

TimGoll commented Jan 14, 2025

Ignore this, wrong issue

@TimGoll
Copy link
Member

TimGoll commented Jan 19, 2025

This part is not yet done, so I'll repopen the issue:

each baserole that has less than 2 subroles installed doesn't have its subrole-layering section displayed leading to confusion when switching between different servers/collections

@TimGoll TimGoll reopened this Jan 19, 2025
Histalek pushed a commit to WardenPotato/TTT2 that referenced this issue Jan 31, 2025
Fixes TTT-2#1700 by showing the enable status of a role.

Also adds the functionality to quickly enable/disable the role right
from the role layering menu.

Looks like this:

![image](https://github.com/user-attachments/assets/ff1bbf59-2c31-420c-a146-6b547a5014cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants