Skip to content

Consider making more things classes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martingkelly opened this issue Jun 7, 2018 · 1 comment
Open

Consider making more things classes #4

martingkelly opened this issue Jun 7, 2018 · 1 comment
Assignees

Comments

@martingkelly
Copy link
Contributor

It may be a natural fit and simplify our function prototypes.

@martingkelly martingkelly self-assigned this Jun 7, 2018
@martingkelly
Copy link
Contributor Author

martingkelly commented Apr 8, 2020

More specifically, we could add the following classes:

  • Project. This would reduce the number of arguments we have to pass into each builder.
  • Manifest. This would make it more natural to access config properties, as opposed to passing loose strings everywhere.
  • Workspace. This would avoid having to pass around root, ws, etc. into every function.

We already have Command classes.

@martingkelly martingkelly changed the title Consider making ws a class Consider making more things classes Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant