Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipping ISO enter and other asymmetrical parts has unintended effects on stabilizer and silk #2

Open
rlake opened this issue Oct 5, 2024 · 1 comment

Comments

@rlake
Copy link

rlake commented Oct 5, 2024

I'm using the library at commit 0b379ee which contains "Breaking Changes Notice (Commit 6e5adad, 2024-08-15)"

When placing the footprints and flipping to put the hot swap socket on the back of the PCB, I noticed a couple of issues with the ISO enter key:

  1. Silkscreen flipped
  2. Stabilizer reversed
    ISOMxRev

There was a similar stabilizer issue with a vertical 2U enter on the numpad. I guess most other keys don't show the issue since they're symmetrical horizontally.

As a workaround, I replaced both with the reversed stabilizer footprints. For the ISO enter specifically, I duplicated the footprint and flipped only the silkscreen outline to make it appear normal.

@ai03-2725
Copy link
Owner

Seems like the issue stems from the most recent breaking change where hotswap sockets were flipped to be topside components without the rest of the footprint being affected.
Solutions I can think of are:

  • Flip every footprint to be switch-side-bottom including the solderable footprints, although this would be unideal due to incurring yet another breaking change for solderable footprint users.
  • Have the generator script mirror the X coordinates of added outlines and stabilizer holes, although there'd need to be some mechanism to mirror only for hotswap - whether by a manual flag, or by detecting some term within the input footprint name (such as "hotswap" or "socket", although that would also require standardization).

I currently don't have the capacity to address this right away, but gut instinct is to go with the script adjustment method with a manual flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants