Skip to content

Graceful shutdown of workers on exq terminate #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akira opened this issue Oct 29, 2014 · 4 comments
Closed

Graceful shutdown of workers on exq terminate #37

akira opened this issue Oct 29, 2014 · 4 comments
Labels

Comments

@akira
Copy link
Owner

akira commented Oct 29, 2014

Have manager shutdown workers and wait for a timeout when a terminate is sent to it. This depends on #5 having a worker pool for workers.

@akira akira added the task label Oct 29, 2014
@j-mcnally
Copy link
Collaborator

would this give workers a chance to cleanup if Manager terminates / application recieves SIGKILL/SIGTERM ?

@akira
Copy link
Owner Author

akira commented Oct 29, 2014

I wasn't thinking of SIGKILL/SIGTERM, I was specifically thinking of calling terminate on the Manager process, which would then terminate it's children with a timeout. Not sure how Erlang handles signals, for that would have to do some research.

@akira
Copy link
Owner Author

akira commented Oct 29, 2014

I had some ideas on the process model for this, need to try it out when I get the chance. Was thinking of looking into an existing worker pool library (like pool_boy, epocxy, or worker_pool) to see if that will help us out any.

@akira
Copy link
Owner Author

akira commented Jan 1, 2016

Implemented by #147

@akira akira closed this as completed Jan 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants