Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REALLY broken #172

Open
WillDev12 opened this issue Mar 19, 2024 · 4 comments
Open

REALLY broken #172

WillDev12 opened this issue Mar 19, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@WillDev12
Copy link

Describe the bug
Refuses to load games, returns HTTP error when getting prices, and much more as I can imagine.

To Reproduce
Steps to reproduce the behavior:

  1. Import
  2. Copy the following code:
from marketwatch import MarketWatch
marketwatch = MarketWatch("username", "password")
out1 = marketwatch.get_price("AAPL")
out2 = marketwatch.get_games()

print(out1)
print(out2)

Expected behavior
Return proper JSON output like it used to

Screenshots

one
two

Desktop (please complete the following information):

  • OS: Chrome
  • Browser: Chrome
  • Version Current

Additional context
THIS USED TO WORK, however now it doesn't.

@antoinebou12
Copy link
Owner

antoinebou12 commented Mar 19, 2024

They changed the api recently i gonna look into it. Need to change the code with playwright because httpx doesn't work anymore

@antoinebou12 antoinebou12 self-assigned this Mar 19, 2024
Copy link

Branch issue-172-REALLY_broken created!

@antoinebou12 antoinebou12 added the enhancement New feature or request label Mar 19, 2024
@antoinebou12
Copy link
Owner

They added a geo blocker to the api and the web pages. What I can do is make the stock api, watchlist works. I am not sure if i can make the game works like before. I will do more tests

@WillDev12
Copy link
Author

That's all right, I'll try to figure out some other stuff in the meantime. Also, one last thing -- There was another problem with the output that returned "Working..." every time a request was made. Not being too familiar with python, stdout was the closest thing I could get to returning the right values to Javascript, but each time I did there was another object sent with that message. It'd be pretty helpful I'm sure if you could try to wire out that as well, but I'm in no hurry so take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants