Skip to content

Improve automation w.r.t. changeset addition #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Shurtu-gal opened this issue Feb 8, 2025 · 15 comments · Fixed by #1653
Closed

Improve automation w.r.t. changeset addition #1652

Shurtu-gal opened this issue Feb 8, 2025 · 15 comments · Fixed by #1653
Assignees
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bounty AsyncAPI Bounty program related label

Comments

@Shurtu-gal
Copy link
Collaborator

Currently the changeset procedure throws a wrench into the current CI/CD pipeline as addition of it is manual.

This leads to the following problems:

  • Automated PRs by bot are merged without changeset leading to no release happening.
  • Sometimes maintainers overlook absence of changesets, leading to critical bug fixes not getting released.

Current POA:
Step 1. Add changeset based on title of pull request.

  • feat --> minor
  • fix --> patch
  • feat! or fix! --> major

Step 2. Messages for releases need to be thought of a little more.
Step 3. Some way to remind contributors to modify changeset.

Note: Just an initial idea in my mind.

Are you willing to work on this issue ?
Yes (at least for now)

@github-project-automation github-project-automation bot moved this to To Triage in CLI - Kanban Feb 8, 2025
@Shurtu-gal Shurtu-gal moved this from To Triage to In progress in CLI - Kanban Feb 8, 2025
@Shurtu-gal Shurtu-gal added the area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. label Feb 8, 2025
@Shurtu-gal
Copy link
Collaborator Author

bounty/candidate

@imabp
Copy link
Member

imabp commented Mar 4, 2025

@Shurtu-gal I would like to work on this.

@Shurtu-gal
Copy link
Collaborator Author

Hello @imabp 👋, great to have you back. Actually I was planning on picking this up 😅.

@imabp
Copy link
Member

imabp commented Mar 4, 2025

Haha, @Shurtu-gal in that case, do we have something else where I can pick up from?
I was just trying to get my hands dirty on things again ❤

@Shurtu-gal
Copy link
Collaborator Author

Sure, there will be multiple ones. Some good candidates might be studio ones like docs generation or installation of google analytics.

You can always scour and find some high priority, difficult issue though.

@aeworxet
Copy link
Contributor

Bounty Issue's service comment

Text labels: bounty/2025-Q2, bounty/advanced, bounty/coding
First assignment to regular contributors: 2025-03-21 00:00:00 UTC+12:00
End Of Life after: 2025-04-30 23:59:59 UTC-12:00

@asyncapi/bounty_team

The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Regular contributors should explain in meaningful words how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Mar 17, 2025
@Shurtu-gal
Copy link
Collaborator Author

I wish to take up this bounty issue.

@Shurtu-gal Shurtu-gal self-assigned this Mar 17, 2025
@aeworxet
Copy link
Contributor

@Shurtu-gal (githubID: 100484401) is an AsyncAPI Maintainer specified in https://github.com/asyncapi/community/blob/master/MAINTAINERS.yaml, so they fall under the first category in the prioritization list.

@aeworxet
Copy link
Contributor

Bounty Issue's Timeline

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2025-03-17 2025-04-07 2025-06-01 2025-04-27 2025-05-18 2025-06-01
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

Assignee: @Shurtu-gal (githubID: 100484401)

@aeworxet aeworxet moved this to In Progress in Bounty Program Mar 19, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Bounty Program Apr 9, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in CLI - Kanban Apr 9, 2025
@Shurtu-gal
Copy link
Collaborator Author

All three steps were done under #1653.
Production testing: #1763 and #1765

@Shurtu-gal
Copy link
Collaborator Author

Shurtu-gal commented Apr 9, 2025

All three steps were done under #1653. Production testing: #1763 and #1765

With this I mark that the bounty issue is completed.

Edit: Just added break to switch under #1766. Me forgetting this 🤦‍♂ .

cc: @aeworxet

@aeworxet
Copy link
Contributor

aeworxet commented Apr 9, 2025

Bounty Issue Is Completed 🎉

@Shurtu-gal (githubID: 100484401), please go to the dedicated AsyncAPI Bounty Program 2025-Q2 page on Open Collective and submit an invoice for USD 400.00 (button 'ACTIONS', dropdown option 'Submit expense') with the expense title Bounty cli#1652, tag bounty, and full URL of this Bounty Issue in the description.

After submitting the invoice, please post the link to it in this Bounty Issue as a separate comment.

@Shurtu-gal
Copy link
Collaborator Author

First release from automated changeset: https://github.com/asyncapi/cli/releases/tag/v3.1.1
All the commit URLs are working pretty well.

@Shurtu-gal
Copy link
Collaborator Author

@aeworxet
Copy link
Contributor

aeworxet commented Apr 9, 2025

Shurtu-gal
https://opencollective.com/asyncapi/projects/asyncapi-bounty-program/expenses/246039


The invoice https://opencollective.com/asyncapi/projects/asyncapi-bounty-program/expenses/246039 was submitted by @Shurtu-gal (githubID: 100484401), who was the AsyncAPI Bounty Program 2025-Q2 Participant and completed the Bounty Issue cli#1652.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bounty AsyncAPI Bounty program related label
Projects
Status: Completed
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants