Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Bug ]: Wrong Time Format 24 hour format mixed with 12 hour format #54

Open
TheSCREWEDSoftware opened this issue Oct 12, 2024 · 5 comments

Comments

@TheSCREWEDSoftware
Copy link

Current Behaviour

https://wowgaming.altervista.org/aowow/?event=64

image

It either should show 24h format only or 12h formart only

22:00 to 23:00
or
10PM to 11PM

Use AzerothCore?

Yes

Steps to reproduce the problem

1 - Go to https://wowgaming.altervista.org/aowow/?event=64
2 - Look at the "Quick Facts"
You will the 2 formats combined.

Extra Notes

No response

Operating system

Windows 10 x64

PHP version

Whatever version the page uses.

Browser

Google Chrome

@TheSCREWEDSoftware
Copy link
Author

Edit: The time is also wrong (of the event): azerothcore/azerothcore-wotlk#20186

@Sarjuuk
Copy link

Sarjuuk commented Oct 16, 2024

'dateFmtLong' => "Y/m/d \a\\t H:i A", in localization/locale_xxxx.php
should either be [...] h:i A or [...] H:i

i can't find a PM date on wowhead and the internet archive still hasn't recovered, so i guess it's the former format...?

either way .. super minor^^

/e: https://www.wowhead.com/wotlk/event=424
it's [...] g:i A

@Helias
Copy link
Member

Helias commented Oct 17, 2024

but then how we should remove the AM/PM format texts? using [...] g:i A ?
I compared this aowow with sarjuuk/aowow and it's the same, we should remove it I guess OR change the time and instead of using 24 time format we could use the 12 ones

btw, I agree it's a minor issue

@Sarjuuk
Copy link

Sarjuuk commented Oct 17, 2024

from https://www.php.net/manual/en/datetime.format.php

g | 12-hour format of an hour without leading zeros (1 - 12)
i | Minutes with leading zeros (00 to 59)
A | Uppercase Ante meridiem and Post meridiem (AM or PM)

and yes, i need to fix that.

@Helias
Copy link
Member

Helias commented Oct 17, 2024

Thanks for the interest.
I hope to align this repo with yours soon, maybe using the PR of pangol/stevej that is in pending, hope to find the time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants