Skip to content

Only run shellcheck againts modified shell files #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pauloparakleto opened this issue Mar 11, 2025 · 1 comment
Open

Only run shellcheck againts modified shell files #410

Pauloparakleto opened this issue Mar 11, 2025 · 1 comment

Comments

@Pauloparakleto
Copy link
Contributor

close #407
@Pauloparakleto
Copy link
Contributor Author

Based in #70 and inspired in @anavarre suggestion, only run shellcheck against modified files.
Developers are free to add they own modified files to the .shellcheckrc list, which is considered in the CI. However, by running ./dev-mode, a pre-commit is created and update the shellcheck list automatically.

By running shellcheck only against modified files is a way to balance inheritance and code quality in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pauloparakleto