Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle-integration tests fail to build charm in the CI #61

Open
orfeas-k opened this issue Jan 11, 2024 · 0 comments
Open

bundle-integration tests fail to build charm in the CI #61

orfeas-k opened this issue Jan 11, 2024 · 0 comments

Comments

@orfeas-k
Copy link
Contributor

orfeas-k commented Jan 11, 2024 •
edited
Loading

Newly implemented CI fails to build the charms during tests. Example runs where this happens are on visualization-server PR and frontend PR. Since, those PRs do not modify the charms themselves, this should be caused by the differences spotted between CI run in this repo and kfp-operators repo which are:

  • ROCKs tests run on ubuntu 22.04 on top of which we install and use Python 3.8 while kfp-operators repo tests run on 20.04
  • ROCKs tests run without destructive-mode like we do in kfp-operators repo, although this shouldn't be causing an issue.

For the moment, we will use placeholder tests in order for the CI to actually publish images (as much as we hate this approach) but we definitely need to investigate this more in order to enable testing of our kfp rocks.
@orfeas-k orfeas-k changed the title bundle-integration tests fail to build charm in the CI integration tests fail to build charm in the CI Jan 11, 2024
@orfeas-k orfeas-k changed the title integration tests fail to build charm in the CI bundle-integration tests fail to build charm in the CI Jan 11, 2024
@orfeas-k orfeas-k mentioned this issue Jan 11, 2024
Merged
orfeas-k added a commit that referenced this issue Jan 12, 2024
@orfeas-k
chore: update visualization-server version and tox.ini file (#57)
8169d0c 
Follow up to #53
- update version according to canonical/bundle-kubeflow#747
- refactor tox.ini according to canonical/oidc-authservice-rock#14 and canonical/bundle-kubeflow#763
- placeholder sanity tests due to #59 and integration due to #61

Refs #44
@orfeas-k orfeas-k mentioned this issue Jan 12, 2024
Merged
orfeas-k added a commit that referenced this issue Jan 15, 2024
@orfeas-k
fix: update frontend version and tox.ini file (#60)
d4ac42b 
Follow up PR to #51

- update version according to canonical/bundle-kubeflow#747
- refactor tox.ini according to canonical/oidc-authservice-rock#14 and canonical/bundle-kubeflow#763
- fix canonical/kfp-operators#337
- add comment about `command`
- use placeholder instead of bundle-integration tests due to #61 (there are no charm integration tests for this charm)
- add placeholder instead of sanity tests since there are none at the moment  

Refs #43
Fixes canonical/kfp-operators#337
This was referenced Jan 15, 2024
Merged
Merged
Merged
orfeas-k added a commit that referenced this issue Jan 16, 2024
@orfeas-k
bump viewer-crd-controller rock to ckf-1.8 (kfp 2.0.3) (#63)
d89d9fc 
- bump source version from `2.0.0-alpha.7` to `2.0.3`
- update according to canonical/bundle-kubeflow#747
- rename base to ubuntu@20.04 as per new `rockcraft` syntax
- use `1.20/stable` snap for Go
- refactor `tox.ini` according to canonical/oidc-authservice-rock#14 and canonical/bundle-kubeflow#763
- use placeholder instead of bundle-integration tests due to #61 (there are no charm integration tests for this charm)
- add placeholder instead of sanity tests since there are none at the moment

Closes #48
orfeas-k added a commit that referenced this issue Jan 16, 2024
@orfeas-k
bump scheduledworkflow rock to ckf-1.8 (kfp 2.0.3) (#64)
7d6d3e4 
- bump source version from `2.0.0-alpha.7` to `2.0.3`
- update according to canonical/bundle-kubeflow#747
- rename base to ubuntu@20.04 as per new `rockcraft` syntax
- use `1.20/stable` snap for Go
- refactor `tox.ini` according to canonical/oidc-authservice-rock#14 and canonical/bundle-kubeflow#763
- use placeholder instead of bundle-integration tests due to #61 (there are no charm integration tests for this charm)
- add placeholder instead of sanity tests since there are none at the moment

Closes #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orfeas-k