Handle 'order already executed/filled' BE states #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

elena-zh opened this issue Apr 2, 2025 · 0 comments

Labels

Bug Low

Contributor

elena-zh commented Apr 2, 2025 •

edited

Loading

Reported in #5549 (comment) (cases 9 and 10)

no handling of 'order already executed' state when a user tried to cancel an order that is already filled.
To reproduce:

place an order
while it is opened, send cancel order request to the wallet, but not execute it
when the order is filled, press on the sign the cancellation request in the wallet

no handling of 'order already expired' state when a user tried to cancel an order that is already expired.
To reproduce:

place an order (2 min duration with 0 slippage)
while it is opened, send cancel order request to the wallet, but not execute it
wait till the order's expiration time comes
press on the sign the cancellation request in the wallet

Expected: show a modal with these texts (accordigly to a situation)

elena-zh added Bug Low labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment