Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinpoint commits where error occurred #39

Open
sdemos opened this issue Oct 2, 2017 · 1 comment
Open

Pinpoint commits where error occurred #39

sdemos opened this issue Oct 2, 2017 · 1 comment

Comments

@sdemos
Copy link

sdemos commented Oct 2, 2017

This comes up in particularly large commits like the rust rewrites of coreos-metadata and update-ssh-keys, but I think giving more guidance as to which commit broke which rules would be pretty useful.

related, maybe there should be a separate error message for each commit which fails a particular check? I think that becomes a natural way to display the errors if they become commit-specific.

seems related to #25 but I thought I would add a new issue that was more specific.

@crawford
Copy link
Owner

crawford commented Oct 2, 2017

I agree this would be great. I'm not sure how Tailor would determine this from it's expression language though. Maybe it would be possible to hold back-references to the underlying context where a rule failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants