Skip to content

Commit bab2aa3

Browse files
[CI][workflows] Use node 20 by default
Prepare for node.js 18 EoL and transition to node 20 as default - start using node 20 for jobs like linting, publishing and license check - Add Node 20 and node 22 to the matrix for "build and test" job - (for now) Keep node 18 as part of the "matrix" for "build and test job". We can remove it once officially EoL The plan is to remove node 18 soon, when it's officially EoL. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
1 parent 902d07e commit bab2aa3

File tree

2 files changed

+20
-11
lines changed

2 files changed

+20
-11
lines changed

.github/workflows/ci-cd.yml

+17-8
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,25 @@ on:
1717

1818
jobs:
1919
build-and-test:
20-
name: Build and test
20+
name: Build and test (${{ matrix.os }}, node-${{ matrix.node-version }})
2121
runs-on: ${{ matrix.os }}
2222

2323
strategy:
2424
fail-fast: false
2525
matrix:
2626
os: [ubuntu-latest]
27-
node: [18]
27+
node-version: [18,20,22]
2828

2929
steps:
3030
- name: Checkout
3131
uses: actions/checkout@v4
3232
with:
3333
persist-credentials: false
3434

35-
- name: Use Node.js ${{ matrix.node }}
35+
- name: Use Node.js ${{ matrix.node-node-version }}
3636
uses: actions/setup-node@v4
3737
with:
38-
node-version: ${{ matrix.node }}
38+
node-version: ${{ matrix.node-version }}
3939

4040
- name: Build
4141
shell: bash
@@ -55,13 +55,17 @@ jobs:
5555
name: Publish 'next' package to npm
5656
needs: build-and-test
5757
if: github.ref == 'refs/heads/master' && github.event_name == 'push' && github.repository == 'eclipse-cdt-cloud/tsp-typescript-client'
58-
runs-on: ubuntu-latest
58+
runs-on: ${{ matrix.os }}
59+
strategy:
60+
matrix:
61+
os: [ubuntu-latest]
62+
node-version: [20]
5963

6064
steps:
6165
- uses: actions/checkout@v4
6266
- uses: actions/setup-node@v4
6367
with:
64-
node-version: '18'
68+
node-version: ${{ matrix.node-version }}
6569
registry-url: 'https://registry.npmjs.org'
6670
- run: yarn --frozen-lockfile
6771
- name: Publish 'next'
@@ -81,12 +85,17 @@ jobs:
8185
name: Publish 'latest' package to npm
8286
needs: build-and-test
8387
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'eclipse-cdt-cloud/tsp-typescript-client'
84-
runs-on: ubuntu-latest
88+
runs-on: ${{ matrix.os }}
89+
strategy:
90+
matrix:
91+
os: [ubuntu-latest]
92+
node-version: [20]
93+
8594
steps:
8695
- uses: actions/checkout@v4
8796
- uses: actions/setup-node@v4
8897
with:
89-
node-version: '18'
98+
node-version: ${{ matrix.node-version }}
9099
registry-url: 'https://registry.npmjs.org'
91100
- run: yarn --frozen-lockfile
92101
- name: Publish 'latest'

.github/workflows/license-check-workflow.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ on:
1414
jobs:
1515

1616
License-check:
17-
name: 3PP License Check using dash-licenses
17+
name: 3PP License Check using dash-licenses (${{ matrix.os }})
1818

1919
strategy:
2020
fail-fast: false
2121
matrix:
2222
os: [ubuntu-latest]
23-
node: [18]
23+
node-version: [20]
2424
java: [11]
2525

2626
runs-on: ${{ matrix.os }}
@@ -35,7 +35,7 @@ jobs:
3535
- name: Use Node.js ${{ matrix.node }}
3636
uses: actions/setup-node@v4
3737
with:
38-
node-version: ${{ matrix.node }}
38+
node-version: ${{ matrix.node-version }}
3939

4040
- name: Use Java ${{ matrix.java }}
4141
uses: actions/setup-java@v3

0 commit comments

Comments
 (0)