Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Commit 0279214

Browse files
authored
Merge pull request #53 from ergebnis/fix/php7.1
Fix: Bring back support for PHP 7.1
2 parents 76494d9 + 427d6c3 commit 0279214

File tree

6 files changed

+162
-192
lines changed

6 files changed

+162
-192
lines changed

.github/settings.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,12 @@ branches:
1010
required_approving_review_count: 1
1111
required_status_checks:
1212
contexts:
13-
- "Coding Standards (7.2, locked)"
13+
- "Coding Standards (7.1, locked)"
1414
- "Dependency Analysis (7.4, locked)"
1515
- "Static Code Analysis (7.4, locked)"
16+
- "Tests (7.1, lowest)"
17+
- "Tests (7.1, locked)"
18+
- "Tests (7.1, highest)"
1619
- "Tests (7.2, lowest)"
1720
- "Tests (7.2, locked)"
1821
- "Tests (7.2, highest)"

.github/workflows/continuous-integration.yml

+11-7
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
strategy:
2020
matrix:
2121
php-version:
22-
- 7.2
22+
- 7.1
2323

2424
dependencies:
2525
- locked
@@ -152,6 +152,7 @@ jobs:
152152
strategy:
153153
matrix:
154154
php-version:
155+
- 7.1
155156
- 7.2
156157
- 7.3
157158
- 7.4
@@ -221,7 +222,7 @@ jobs:
221222
- name: "Install PHP with extensions"
222223
uses: shivammathur/setup-php@1.6.1
223224
with:
224-
coverage: pcov
225+
coverage: xdebug
225226
extensions: "mbstring"
226227
php-version: ${{ matrix.php-version }}
227228

@@ -236,8 +237,11 @@ jobs:
236237
- name: "Install locked dependencies with composer"
237238
run: composer install --no-interaction --no-progress --no-suggest
238239

239-
- name: "Collect code coverage with pcov and phpunit/phpunit"
240-
run: vendor/bin/phpunit --configuration=test/Unit/phpunit.xml --coverage-clover=.build/logs/clover.xml
240+
- name: "Dump Xdebug filter with phpunit/phpunit"
241+
run: vendor/bin/phpunit --configuration=test/Unit/phpunit.xml --dump-xdebug-filter=.build/phpunit/xdebug-filter.php
242+
243+
- name: "Collect code coverage with Xdebug and phpunit/phpunit"
244+
run: vendor/bin/phpunit --configuration=test/Unit/phpunit.xml --coverage-clover=build/logs/clover.xml --prepend=.build/phpunit/xdebug-filter.php
241245

242246
- name: "Send code coverage report to Codecov.io"
243247
env:
@@ -264,7 +268,7 @@ jobs:
264268
- name: "Install PHP with extensions"
265269
uses: shivammathur/setup-php@1.6.1
266270
with:
267-
coverage: pcov
271+
coverage: xdebug
268272
extensions: "mbstring"
269273
php-version: ${{ matrix.php-version }}
270274

@@ -279,5 +283,5 @@ jobs:
279283
- name: "Install locked dependencies with composer"
280284
run: composer install --no-interaction --no-progress --no-suggest
281285

282-
- name: "Run mutation tests with pcov and infection/infection"
283-
run: vendor/bin/infection --ignore-msi-with-no-mutations --min-covered-msi=96 --min-msi=92
286+
- name: "Run mutation tests with Xdebug and infection/infection"
287+
run: vendor/bin/infection --ignore-msi-with-no-mutations --min-covered-msi=94 --min-msi=94

CHANGELOG.md

+13-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## Unreleased
88

9-
For a full diff see [`2.0.0...master`][2.0.0...master].
9+
For a full diff see [`2.0.1...master`][2.0.1...master].
10+
11+
## [`2.0.1`][2.0.1]
12+
13+
For a full diff see [`2.0.0...2.0.1`][2.0.0...2.0.1].
14+
15+
### Fixed
16+
17+
* Brought back support for PHP 7.1 ([#53]), by [@localheinz]
1018

1119
## [`2.0.0`][2.0.0]
1220

@@ -83,12 +91,14 @@ For a full diff see [`149a393...1.0.0`][149a393...1.0.0].
8391
[1.0.1]: https://github.com/ergebnis/composer-json-normalizer/releases/tag/1.0.1
8492
[1.0.2]: https://github.com/ergebnis/composer-json-normalizer/releases/tag/1.0.2
8593
[2.0.0]: https://github.com/ergebnis/composer-json-normalizer/releases/tag/2.0.0
94+
[2.0.1]: https://github.com/ergebnis/composer-json-normalizer/releases/tag/2.0.1
8695

8796
[149a393...1.0.0]: https://github.com/ergebnis/composer-json-normalizer/compare/149a393...1.0.0
8897
[1.0.0...1.0.1]: https://github.com/ergebnis/composer-json-normalizer/compare/1.0.0...1.0.1
8998
[1.0.1...1.0.2]: https://github.com/ergebnis/composer-json-normalizer/compare/1.0.1...1.0.2
9099
[1.0.2...2.0.0]: https://github.com/ergebnis/composer-json-normalizer/compare/1.0.2...2.0.0
91-
[2.0.0...master]: https://github.com/ergebnis/composer-json-normalizer/compare/2.0.0...master
100+
[2.0.0...2.0.1]: https://github.com/ergebnis/composer-json-normalizer/compare/2.0.0...2.0.1
101+
[2.0.1...master]: https://github.com/ergebnis/composer-json-normalizer/compare/2.0.1...master
92102

93103
[#1]: https://github.com/ergebnis/composer-json-normalizer/pull/1
94104
[#2]: https://github.com/ergebnis/composer-json-normalizer/pull/2
@@ -98,6 +108,7 @@ For a full diff see [`149a393...1.0.0`][149a393...1.0.0].
98108
[#44]: https://github.com/ergebnis/composer-json-normalizer/pull/44
99109
[#45]: https://github.com/ergebnis/composer-json-normalizer/pull/45
100110
[#47]: https://github.com/ergebnis/composer-json-normalizer/pull/47
111+
[#53]: https://github.com/ergebnis/composer-json-normalizer/pull/53
101112

102113
[@ergebnis]: https://github.com/ergebnis
103114
[@localheinz]: https://github.com/localheinz

Makefile

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ it: coding-standards dependency-analysis static-code-analysis tests ## Runs the
33

44
.PHONY: code-coverage
55
code-coverage: vendor ## Collects coverage from running unit tests with phpunit/phpunit
6-
vendor/bin/phpunit --configuration=test/Unit/phpunit.xml --coverage-text
6+
mkdir -p .build/phpunit
7+
vendor/bin/phpunit --configuration=test/Unit/phpunit.xml --dump-xdebug-filter=.build/phpunit/xdebug-filter.php
8+
vendor/bin/phpunit --configuration=test/Unit/phpunit.xml --coverage-text --prepend=.build/phpunit/xdebug-filter.php
79

810
.PHONY: coding-standards
911
coding-standards: vendor ## Fixes code style issues with friendsofphp/php-cs-fixer
@@ -21,7 +23,7 @@ help: ## Displays this list of targets with descriptions
2123
.PHONY: mutation-tests
2224
mutation-tests: vendor ## Runs mutation tests with infection/infection
2325
mkdir -p .build/infection
24-
vendor/bin/infection --ignore-msi-with-no-mutations --min-covered-msi=96 --min-msi=92
26+
vendor/bin/infection --ignore-msi-with-no-mutations --min-covered-msi=94 --min-msi=94
2527

2628
.PHONY: static-code-analysis
2729
static-code-analysis: vendor ## Runs a static code analysis with phpstan/phpstan

composer.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
}
1717
],
1818
"require": {
19-
"php": "^7.2",
19+
"php": "^7.1",
2020
"ext-json": "*",
21-
"ergebnis/json-normalizer": "~0.10.0",
21+
"ergebnis/json-normalizer": "~0.10.1",
2222
"justinrainbow/json-schema": "^4.0.0 || ^5.0.0"
2323
},
2424
"require-dev": {
@@ -31,7 +31,7 @@
3131
"phpstan/phpstan": "~0.11.19",
3232
"phpstan/phpstan-deprecation-rules": "~0.11.2",
3333
"phpstan/phpstan-strict-rules": "~0.11.1",
34-
"phpunit/phpunit": "^8.5.0"
34+
"phpunit/phpunit": "^7.5.18"
3535
},
3636
"config": {
3737
"preferred-install": "dist",

0 commit comments

Comments
 (0)