Skip to content

Commit 75d630a

Browse files
fabioformosafabioformosa
authored
Merge pull request #110 from midhunadarvin/feat/configure-trigger-job-data
feat: configure `Trigger` JobDataMap
2 parents fa4ede5 + 9eddc0b commit 75d630a

File tree

10 files changed

+151
-5
lines changed

10 files changed

+151
-5
lines changed

‎.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
/.project
2+
.idea
3+
*.iml

‎quartz-manager-parent/.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@
44
.classpath
55
.project
66
.idea
7+
*.iml

‎quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/converters/SimpleTriggerCommandDTOToSimpleTrigger.java

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33

44
import it.fabioformosa.quartzmanager.api.dto.SimpleTriggerCommandDTO;
5+
import org.quartz.JobDataMap;
56
import org.quartz.SimpleScheduleBuilder;
67
import org.quartz.SimpleTrigger;
78
import org.quartz.Trigger;
@@ -19,6 +20,8 @@ public SimpleTrigger convert(SimpleTriggerCommandDTO triggerCommandDTO) {
1920
if (triggerCommandDTO.getSimpleTriggerInputDTO().getEndDate() != null)
2021
triggerTriggerBuilder.endAt(triggerCommandDTO.getSimpleTriggerInputDTO().getEndDate());
2122

23+
if (triggerCommandDTO.getSimpleTriggerInputDTO().getJobDataMap() != null)
24+
triggerTriggerBuilder.usingJobData(new JobDataMap(triggerCommandDTO.getSimpleTriggerInputDTO().getJobDataMap()));
2225

2326
SimpleScheduleBuilder scheduleBuilder = SimpleScheduleBuilder.simpleSchedule();
2427
if (triggerCommandDTO.getSimpleTriggerInputDTO().getRepeatInterval() != null)

‎quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/converters/SimpleTriggerToSimpleTriggerDTO.java

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ protected void convert(SimpleTrigger source, SimpleTriggerDTO target) {
1414
target.setRepeatCount(source.getRepeatCount());
1515
target.setRepeatInterval(source.getRepeatInterval());
1616
target.setMisfireInstruction(source.getMisfireInstruction());
17+
target.setJobDataMap(source.getJobDataMap());
1718
}
1819

1920
@Override

‎quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/dto/SimpleTriggerInputDTO.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@
33
import it.fabioformosa.quartzmanager.api.validators.ValidTriggerRepetition;
44
import lombok.*;
55
import lombok.experimental.SuperBuilder;
6-
6+
import javax.annotation.Nullable;
77
import javax.validation.constraints.Positive;
8+
import java.util.Map;
89

910
@ValidTriggerRepetition
1011
@SuperBuilder
@@ -18,4 +19,7 @@ public class SimpleTriggerInputDTO extends TriggerCommandDTO implements TriggerR
1819

1920
@Positive
2021
private Long repeatInterval;
22+
23+
@Nullable
24+
private Map<String, ?> jobDataMap;
2125
}

‎quartz-manager-parent/quartz-manager-starter-api/src/main/java/it/fabioformosa/quartzmanager/api/dto/TriggerDTO.java

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import lombok.Data;
55
import lombok.NoArgsConstructor;
66
import lombok.experimental.SuperBuilder;
7+
import org.quartz.JobDataMap;
78

89
import java.util.Date;
910

@@ -23,4 +24,5 @@ public class TriggerDTO {
2324
private JobKeyDTO jobKeyDTO;
2425
private JobDetailDTO jobDetailDTO;
2526
private boolean mayFireAgain;
27+
private JobDataMap jobDataMap;
2628
}

‎quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/controllers/SimpleTriggerControllerTest.java

+7-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
import org.springframework.test.web.servlet.result.MockMvcResultMatchers;
2222

2323
import java.util.Date;
24-
24+
import java.util.Map;
25+
import static java.util.Map.entry;
2526
import static org.mockito.ArgumentMatchers.any;
2627
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
2728

@@ -68,13 +69,18 @@ void givenACompleteSimpleTriggerCommandDTO_whenPosted_thenANewSimpleTriggerIsCre
6869
}
6970

7071
private SimpleTriggerInputDTO buildACompleteSimpleTriggerCommandDTO() {
72+
Map<String, ?> triggerJobDataMap = Map.ofEntries(
73+
entry("customTriggerData1", "value1"),
74+
entry("customTriggerData2", "value2")
75+
);
7176
return SimpleTriggerInputDTO.builder()
7277
.jobClass("it.fabioformosa.quartzmanager.api.jobs.SampleJob")
7378
.startDate(new Date())
7479
.endDate(DateUtils.addHoursToNow(6))
7580
.misfireInstruction(MisfireInstruction.MISFIRE_INSTRUCTION_FIRE_NOW)
7681
.repeatCount(5)
7782
.repeatInterval(1000L * 60 * 60)
83+
.jobDataMap(triggerJobDataMap)
7884
.build();
7985
}
8086

‎quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/controllers/utils/TriggerUtils.java

+53-3
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,23 @@
22

33
import it.fabioformosa.quartzmanager.api.common.utils.DateUtils;
44
import it.fabioformosa.quartzmanager.api.dto.*;
5+
import org.quartz.JobDataMap;
6+
import org.quartz.SimpleScheduleBuilder;
7+
import org.quartz.SimpleTrigger;
8+
import org.quartz.Trigger;
9+
import org.quartz.TriggerBuilder;
510

11+
import java.text.ParseException;
12+
import java.text.SimpleDateFormat;
613
import java.time.LocalDateTime;
14+
import java.util.Date;
15+
import java.util.Map;
16+
17+
import static java.util.Map.entry;
718

819
public class TriggerUtils {
920

10-
static public TriggerDTO getTriggerInstance(String triggerName){
21+
static public TriggerDTO getTriggerInstance(String triggerName) {
1122
return TriggerDTO.builder()
1223
.description("sample trigger")
1324
.endTime(DateUtils.addHoursToNow(2L))
@@ -28,7 +39,7 @@ static public TriggerDTO getTriggerInstance(String triggerName){
2839
.build();
2940
}
3041

31-
static public SimpleTriggerDTO getSimpleTriggerInstance(String triggerName, SimpleTriggerInputDTO simpleTriggerInputDTO){
42+
static public SimpleTriggerDTO getSimpleTriggerInstance(String triggerName, SimpleTriggerInputDTO simpleTriggerInputDTO) {
3243
return SimpleTriggerDTO.builder()
3344
.description("simple trigger")
3445
.repeatCount(simpleTriggerInputDTO.getRepeatCount())
@@ -48,10 +59,11 @@ static public SimpleTriggerDTO getSimpleTriggerInstance(String triggerName, Simp
4859
.nextFireTime(DateUtils.addHoursToNow(1L))
4960
.priority(1)
5061
.startTime(DateUtils.fromLocalDateTimeToDate(LocalDateTime.now()))
62+
.jobDataMap(new JobDataMap(simpleTriggerInputDTO.getJobDataMap()))
5163
.build();
5264
}
5365

54-
static public SimpleTriggerDTO getSimpleTriggerInstance(String triggerName){
66+
static public SimpleTriggerDTO getSimpleTriggerInstance(String triggerName) {
5567
return SimpleTriggerDTO.builder()
5668
.description("simple trigger")
5769
.repeatCount(2)
@@ -71,6 +83,44 @@ static public SimpleTriggerDTO getSimpleTriggerInstance(String triggerName){
7183
.nextFireTime(DateUtils.addHoursToNow(1L))
7284
.priority(1)
7385
.startTime(DateUtils.fromLocalDateTimeToDate(LocalDateTime.now()))
86+
.jobDataMap(new JobDataMap(Map.ofEntries(entry("customTriggerData1", "value1"))))
87+
.build();
88+
}
89+
90+
static public SimpleTrigger buildSimpleTrigger() {
91+
TriggerBuilder<Trigger> triggerTriggerBuilder = TriggerBuilder.newTrigger();
92+
triggerTriggerBuilder.startAt(new Date());
93+
triggerTriggerBuilder.endAt(DateUtils.addHoursToNow(1));
94+
triggerTriggerBuilder.usingJobData(new JobDataMap(Map.ofEntries(entry("data", "value"))));
95+
96+
SimpleScheduleBuilder scheduleBuilder = SimpleScheduleBuilder.simpleSchedule();
97+
scheduleBuilder.withIntervalInMilliseconds(1000);
98+
scheduleBuilder.withRepeatCount(1);
99+
scheduleBuilder.withMisfireHandlingInstructionFireNow();
100+
101+
return triggerTriggerBuilder.withSchedule(
102+
scheduleBuilder
103+
)
104+
.withIdentity("simpleTrigger").build();
105+
}
106+
107+
static public SimpleTriggerCommandDTO buildSimpleTriggerCommandDTO(String triggerName) throws ParseException {
108+
SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd");
109+
Date startDate = dateFormat.parse("2024-02-02");
110+
Date endDate = dateFormat.parse("2024-03-02");
111+
112+
SimpleTriggerInputDTO triggerInputDTO = SimpleTriggerInputDTO.builder()
113+
.misfireInstruction(MisfireInstruction.MISFIRE_INSTRUCTION_FIRE_NOW)
114+
.jobClass("sample.jobClass")
115+
.repeatCount(1)
116+
.repeatInterval(1000L)
117+
.startDate(startDate)
118+
.endDate(endDate)
119+
.jobDataMap(Map.ofEntries(entry("data", "value")))
120+
.build();
121+
return SimpleTriggerCommandDTO.builder()
122+
.triggerName(triggerName)
123+
.simpleTriggerInputDTO(triggerInputDTO)
74124
.build();
75125
}
76126

‎quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/converters/SimpleTriggerCommandDTOToSimpleTriggerTest.java

+41
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
package it.fabioformosa.quartzmanager.api.converters;
2+
3+
import it.fabioformosa.quartzmanager.api.controllers.utils.TriggerUtils;
4+
import it.fabioformosa.quartzmanager.api.dto.SimpleTriggerCommandDTO;
5+
import org.assertj.core.api.Assertions;
6+
import org.junit.jupiter.api.MethodOrderer;
7+
import org.junit.jupiter.api.Order;
8+
import org.junit.jupiter.api.Test;
9+
import org.junit.jupiter.api.TestMethodOrder;
10+
import org.quartz.SimpleTrigger;
11+
import org.springframework.beans.factory.annotation.Autowired;
12+
import org.springframework.boot.test.context.SpringBootTest;
13+
import org.springframework.core.convert.ConversionService;
14+
15+
import java.text.ParseException;
16+
import java.text.SimpleDateFormat;
17+
import java.util.Date;
18+
19+
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
20+
@SpringBootTest
21+
class SimpleTriggerCommandDTOToSimpleTriggerTest {
22+
23+
@Autowired
24+
private ConversionService conversionService;
25+
26+
@Order(1)
27+
@Test
28+
void givenSimpleTriggerCommandDTO_whenItIsConverted_thenASimpleTriggerIsReturned() throws ParseException {
29+
SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd");
30+
Date startDate = dateFormat.parse("2024-02-02");
31+
Date endDate = dateFormat.parse("2024-03-02");
32+
SimpleTriggerCommandDTO simpleTriggerCommandDTO = TriggerUtils.buildSimpleTriggerCommandDTO("mytrigger");
33+
SimpleTrigger simpleTrigger = conversionService.convert(simpleTriggerCommandDTO, SimpleTrigger.class);
34+
Assertions.assertThat(simpleTrigger).isNotNull();
35+
Assertions.assertThat(simpleTrigger.getRepeatCount()).isEqualTo(simpleTriggerCommandDTO.getSimpleTriggerInputDTO().getRepeatCount());
36+
Assertions.assertThat(simpleTrigger.getRepeatInterval()).isEqualTo(simpleTriggerCommandDTO.getSimpleTriggerInputDTO().getRepeatInterval());
37+
Assertions.assertThat(simpleTrigger.getJobDataMap()).containsEntry("data", "value");
38+
Assertions.assertThat(simpleTrigger.getStartTime()).isEqualTo(startDate);
39+
Assertions.assertThat(simpleTrigger.getEndTime()).isEqualTo(endDate);
40+
}
41+
}

‎quartz-manager-parent/quartz-manager-starter-api/src/test/java/it/fabioformosa/quartzmanager/api/converters/SimpleTriggerToSimpleTriggerDTOTest.java

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
package it.fabioformosa.quartzmanager.api.converters;
2+
3+
import it.fabioformosa.quartzmanager.api.controllers.utils.TriggerUtils;
4+
import it.fabioformosa.quartzmanager.api.dto.SimpleTriggerDTO;
5+
import org.assertj.core.api.Assertions;
6+
import org.junit.jupiter.api.MethodOrderer;
7+
import org.junit.jupiter.api.Order;
8+
import org.junit.jupiter.api.Test;
9+
import org.junit.jupiter.api.TestMethodOrder;
10+
import org.quartz.SimpleTrigger;
11+
import org.springframework.beans.factory.annotation.Autowired;
12+
import org.springframework.boot.test.context.SpringBootTest;
13+
import org.springframework.core.convert.ConversionService;
14+
15+
16+
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
17+
@SpringBootTest
18+
class SimpleTriggerToSimpleTriggerDTOTest {
19+
20+
@Autowired
21+
private ConversionService conversionService;
22+
23+
@Order(1)
24+
@Test
25+
void givenSimpleTrigger_whenItIsConverted_thenADtoIsReturned() {
26+
SimpleTrigger simpleTrigger = TriggerUtils.buildSimpleTrigger();
27+
SimpleTriggerDTO simpleTriggerDTO = conversionService.convert(simpleTrigger, SimpleTriggerDTO.class);
28+
Assertions.assertThat(simpleTriggerDTO).isNotNull();
29+
Assertions.assertThat(simpleTriggerDTO.getRepeatCount()).isEqualTo(simpleTrigger.getRepeatCount());
30+
Assertions.assertThat(simpleTriggerDTO.getRepeatInterval()).isEqualTo(simpleTrigger.getRepeatInterval());
31+
Assertions.assertThat(simpleTriggerDTO.getJobDataMap()).containsEntry("data", "value");
32+
Assertions.assertThat(simpleTriggerDTO.getStartTime()).isEqualTo(simpleTrigger.getStartTime());
33+
Assertions.assertThat(simpleTriggerDTO.getEndTime()).isEqualTo(simpleTrigger.getEndTime());
34+
}
35+
}
36+

0 commit comments

Comments
 (0)