Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Consistency Checks to All Priority Calculation Methods #11

Open
mestinso opened this issue Feb 27, 2017 · 3 comments
Open

Add Consistency Checks to All Priority Calculation Methods #11

mestinso opened this issue Feb 27, 2017 · 3 comments

Comments

@mestinso
Copy link
Contributor

mestinso commented Feb 27, 2017

I am not sure why consistency checks are not a part of geomean and normalized mean methods. I would argue they should always be used and included.

Either lamdaMax could be calculated the proper way (same as eigenvalue method) or by using the standard lamdaMax estimation approach. Maybe the lamdaMax estimation approach makes the most sense here, since the only time you will know lamdaMax precisely is when you use the eigenvalue approach.

Thoughts?

@gluc
Copy link
Owner

gluc commented Feb 27, 2017

Yes, you're probably right. Volunteers for a pull request?

@mestinso
Copy link
Contributor Author

I'll take a look at implementing this one in the next couple days. Any preference on lambaMax calculation method? I'm leaning towards using the estimated approach.

@gluc
Copy link
Owner

gluc commented Feb 27, 2017

Thx! I'm really not the expert here, estimated approach sounds fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants