This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Add tests for connection lines starting from pins #3
Labels
test
Something wrong or not covered in the test suites
Comments
|
And this is what happens when there's no tests for it. Instead of defining rshift, we defined an lshift twice: https://github.com/google/pcbdl/blob/master/pcbdl/base.py#L370 Ty @crcollins for the discovery. |
amstan
added a commit
that referenced
this issue
Jan 15, 2020
* Documentation in rest format * Added a ton more docstrings * Massaged __init__.py so it imports a bunch of things * Fixed bug with double Pin.__lshift__ (from issue #3) TEST=make doc Signed-off-by: Alexandru M Stan <alex@hypertriangle.com>
amstan
added a commit
that referenced
this issue
Jan 15, 2020
* Documentation in rest format * Added a ton more docstrings * Massaged __init__.py so it imports a bunch of things * Fixed bug with double Pin.__lshift__ (from issue #3) TEST=make doc Signed-off-by: Alexandru M Stan <alex@hypertriangle.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In d53d183 I added to the functionality that allows a Pin to be used instead of a Net for a lot of cases.
Should write tests for that.
Perhaps make a Connectable protocol: something that implements
.connect,.__lshift__and.__rshift__. Pin and Net would both support it.The text was updated successfully, but these errors were encountered: