Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump graphql-core version to fix concurrency / security issues #70

Closed
jnak opened this issue Jan 23, 2020 · 0 comments · Fixed by #74
Closed

Bump graphql-core version to fix concurrency / security issues #70

jnak opened this issue Jan 23, 2020 · 0 comments · Fixed by #74

Comments

@jnak
Copy link

jnak commented Jan 23, 2020

Hi,

graphql-core 2.3.0 contains a fix for the concurrency issues that have been reported in flask-graphql (e.g. #43). Given Flask rely heavily on thread-scoped global variables, I would recommend you bump the minimum version for graphql-core in setup.py to completely prevent these security errors from happening.

See https://github.com/graphql-python/graphql-core/pull/260#issue-356659503 for more context.

Cheers,
J
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update context and root executor options
1 participant
@jnak