Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for Kong Enterprise Entities #17

Open
tjrivera opened this issue Apr 14, 2020 · 7 comments
Open

Feature request: Add support for Kong Enterprise Entities #17

tjrivera opened this issue Apr 14, 2020 · 7 comments

Comments

@tjrivera
Copy link
Contributor

I'd like to build out the capabilities of this library to support Enterprise Edition entities. This would cover general CRUD operations around:

  • Workspaces
  • Workspace entities
  • Users
  • Admins
  • Roles
  • Endpoint permissions
  • Entity permissions

This work is intended as a port of work completed here: kevholditch/gokong#74 with the goal of eventual implementation in a Kong Terraform provider, as well as decK.

@hbagdi
Copy link
Owner

hbagdi commented Apr 15, 2020

Thanks, can we open a PR for each separately please?
The library is used in a lot of places in production and any slip here will have wide ramification.

Also, there are many to many implications for the RBAC entities and we will be careful into how we add support for those in this library and especially decK.

@hbagdi
Copy link
Owner

hbagdi commented Apr 15, 2020

@tjrivera Can you or someone you know from the community also start porting over the terraform provider to this library?

@tjrivera
Copy link
Contributor Author

tjrivera commented Apr 15, 2020

@hbagdi I agree separate PRs make sense here.

I can work on a terraform provider port as it's directly applicable to the use case we have, in which case it may make sense for someone else to chip away at implementing these entities while that is happening.

I know @marcelometal's team has less use for the terraform provider but would still find these entities useful in the client context. If they have the cycles to dig into this that would be awesome! If not, I totally understand. I can also chip away as I'm able. Just trying to find the best way to parallelize this work :)

@hbagdi
Copy link
Owner

hbagdi commented Apr 20, 2020

Sounds good, @tjrivera!
Keep me posted and let me know if you need any help.

@hbagdi
Copy link
Owner

hbagdi commented Apr 28, 2020

Hey @tjrivera,

I've seen your PRs but haven't had time to review them yet. I just wanted to let you know that I've not forgotten about them and I'll get to them. It has been crazy busy lately as a lot of things are in motion currently. Thanks for your patience and hard-work. Truly appreciated!

@tjrivera
Copy link
Contributor Author

Hey @hbagdi,

All good, I totally understand. If you're looking to prioritize, #22 Is a lightweight PR that would unblock some of the terraform-provider work happening in kevholditch/terraform-provider-kong#104.

I also have work on a branch on my fork that adds the rest of RBAC support (users, roles, permissions). After that, I plan on adding Workspace entities.

Thanks,
Tyler

@tjrivera
Copy link
Contributor Author

Just a quick update on this... I have support for all of the entities mentioned in this issue on the ee-support branch on my fork. I haven't submitted it because it's a lot, and I'm having trouble deciding on how I could break it up logically for easier review. I have some projects at work that needed this support, so I prioritized speed and completeness over ease of contribution. That being said, just wanted to let folks know that that work exists and that I could submit the whole PR now, or as time allows break it up into more digestible changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants