Skip to content

Create alert for contributor user name and email modification #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Misjohns opened this issue Feb 25, 2025 · 1 comment
Open

Create alert for contributor user name and email modification #617

Misjohns opened this issue Feb 25, 2025 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed UX Related to the user experience
Milestone

Comments

@Misjohns
Copy link
Collaborator

Misjohns commented Feb 25, 2025

Contributor name and email MUST match GitHub account to avoid DCO failure

If a user alters the contributor Information section (user name and email), we need to warn them that these must match the name and email associated with their GitHub account for InstructLab to successfully submit their contribution. If these do not match, they will receive a DCO failure.

@Misjohns Misjohns added the UX Related to the user experience label Feb 25, 2025
@Misjohns Misjohns added this to the release-1.1 milestone Feb 25, 2025
@Misjohns Misjohns self-assigned this Feb 25, 2025
@Misjohns Misjohns added this to UI Feb 25, 2025
@Misjohns Misjohns modified the milestones: release-1.1, release-1.2 Feb 25, 2025
@Misjohns Misjohns changed the title Create alert for author user name and email modification Create alert for contributor user name and email modification Feb 25, 2025
@Misjohns
Copy link
Collaborator Author

Knowledge contribution: Details > Contributor information

On the Details step, the UI auto-populates the contributor's name and email based on the GitHub account the user used during sign-in. If a user clicks on the pencil icon the Edit contributor information modal displays.

Image

This modal will display information about the importance of their name and email matching their GitHub account for proper DCO sign-off. If user modifies the fields they will update on the Details step of the wizard.
Image

Questions/concerns:

  1. Some SMEs might not know what DCO signoff is or even how to verify what their GH name and email are.
  2. Can/should a user modify their name/email per contribution?
  3. If a user has more than a single GH account, do they have multiple iLab accounts?
  4. Should this be handled at a higher level? A user's GH account populates their InstructLab profile and a user would need to modify any changes there?
  5. How does a SME know their DCO has failed? Not indication in their dashboard currently. Do we need to support?
  6. Need to advise the user that their GH email MUST be public. Can we resolve/enforce this during login?
    @vishnoianil @nerdalert

@vishnoianil vishnoianil moved this to Ready in UI Mar 4, 2025
@vishnoianil vishnoianil added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 4, 2025
@Misjohns Misjohns removed their assignment Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed UX Related to the user experience
Projects
Status: Ready
Development

No branches or pull requests

2 participants