Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up pre-commit for the project #62

Open
0x0elliot opened this issue Oct 20, 2022 · 4 comments
Open

Set up pre-commit for the project #62

0x0elliot opened this issue Oct 20, 2022 · 4 comments
Assignees

Comments

@0x0elliot
Copy link
Member

0x0elliot commented Oct 20, 2022

While I am at it, I would also set up pre-commit for this project like there exists for IntelOwl and PyIntelOwl.

@0x0elliot 0x0elliot self-assigned this Oct 20, 2022
@0x0elliot 0x0elliot removed their assignment Nov 8, 2022
@0x0elliot
Copy link
Member Author

i have gotten a bit busier this month. i am leaving this issue for the community for the time being. would come back to this when i am free.

@ashutosh887
Copy link

Let me work on this @0x0elliot
Please assign

@pranjalg1331
Copy link

pranjalg1331 commented Feb 2, 2025

Hi @mlodic,
I’m looking to set up a pre-commit hook for the Go SDK and am considering using the pre-configured hooks from dnephin/pre-commit-golang. I’m unsure about the user flow.
Should we:
Require users to install the pre-commit library, or
Provide a script to copy a sample pre-commit file into .git/hooks/?
Please let me know what you think, and feel free to assign this issue to me. 😄

@mlodic mlodic assigned pranjalg1331 and unassigned ashutosh887 Feb 5, 2025
@mlodic
Copy link
Member

mlodic commented Feb 5, 2025

Require users to install the pre-commit library, or

That is impossible to force but surely this would need to be suggested in the documentation of the library.

Then, you can add a pre-commit file like we did with pyintelowl here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants