Skip to content

Commit 8caa4e8

Browse files
authored
Add validation for players season totals (#294)
1 parent cc71014 commit 8caa4e8

File tree

1 file changed

+23
-1
lines changed

1 file changed

+23
-1
lines changed

tests/end to end/test_client.py

+23-1
Original file line numberDiff line numberDiff line change
@@ -200,5 +200,27 @@ def test_2018(self):
200200
totals = players_season_totals(season_end_year=2018)
201201

202202
for total in totals:
203+
# TODO: @jaebradley turn this into a dataclass with validation
203204
self.assertIsNot("", total["name"])
204-
self.assertIsNot("League Average", total["name"])
205+
self.assertIsNot("League Average", total["name"])
206+
self.assertTrue(total["slug"])
207+
self.assertTrue(total["name"])
208+
self.assertTrue(total["positions"])
209+
self.assertGreater(total["age"], 0)
210+
self.assertGreaterEqual(total["games_played"], 0)
211+
self.assertGreaterEqual(total["games_started"], 0)
212+
self.assertGreaterEqual(total["minutes_played"], 0)
213+
self.assertGreaterEqual(total["made_field_goals"], 0)
214+
self.assertGreaterEqual(total["attempted_field_goals"], total["made_field_goals"])
215+
self.assertGreaterEqual(total["made_three_point_field_goals"], 0)
216+
self.assertGreaterEqual(total["attempted_three_point_field_goals"], total["made_three_point_field_goals"])
217+
self.assertGreaterEqual(total["made_free_throws"], 0)
218+
self.assertGreaterEqual(total["attempted_free_throws"], total["made_free_throws"])
219+
self.assertGreaterEqual(total["offensive_rebounds"], 0)
220+
self.assertGreaterEqual(total["defensive_rebounds"], 0)
221+
self.assertGreaterEqual(total["assists"], 0)
222+
self.assertGreaterEqual(total["steals"], 0)
223+
self.assertGreaterEqual(total["blocks"], 0)
224+
self.assertGreaterEqual(total["turnovers"], 0)
225+
self.assertGreaterEqual(total["personal_fouls"], 0)
226+
self.assertGreaterEqual(total["points"], 0)

0 commit comments

Comments
 (0)