Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges on player card and profile #15

Open
jamesgiu opened this issue Jun 22, 2021 · 25 comments · Fixed by #54
Open

Badges on player card and profile #15

jamesgiu opened this issue Jun 22, 2021 · 25 comments · Fixed by #54
Labels
Backend enhancement New feature or request UI

Comments

@jamesgiu
Copy link
Owner

Being a nemesis or victim should be reflected as an icon on someone's player card

Tournament winners should earn badges for their win (maybe the tournament creator can choose an image or have it based on an svg icon, e.g. a golden thumbs up for one tournament)

@jamesgiu jamesgiu added Backend enhancement New feature or request UI labels Jun 22, 2021
@ChrisNeedham24
Copy link
Collaborator

ChrisNeedham24 commented Jun 24, 2021

Badge/achievement ideas:

  • Clutch Performer: Win 5 games by 2 points or less ✅
  • Heart Breaker: Lose 5 games by 2 points or less ✅
  • Chicken Dinner: Win a tournament ✅
  • Sacked: Beat Frank (my personal favourite)
  • On A Roll: Win 3 games in a row ✅
  • Unstoppable: Win 5 games in a row ✅
  • Ascended: Win 10 games in a row ✅
  • Fatality: Win a game without losing a point (to 11 or more) ✅
  • Helpless: Lose a game without winning a point (to 11 or more) ✅
  • Superior: Reach 1300 ELO ✅

I'll add more if I think of any.

@jamesgiu
Copy link
Owner Author

LOL at Sacked

@jamesgiu
Copy link
Owner Author

jamesgiu commented Jun 24, 2021

I'd love to work on the initial cut of this ticket, maybe tonight/tomorrow (RDO) ;) ??

@jamesgiu
Copy link
Owner Author

Rancher: Have a 5 game winning streak against someone
Boar Farmer: Have a 10 game winning streak against someone
It Ain't Much But it's Honest Work: Have a 15 game winning streak against someone
Heartless: Beat your current Victim 5 times in a row

@jamesgiu
Copy link
Owner Author

Question: can you get the same achievement twice? E.g. if you get it against 2 different players?

@jamesgiu
Copy link
Owner Author

With the amount of calculations required, this'll definitely be a backend thing I think (e.g. checking for triggers and recording the achievement in the DB after a game has been entered)

@ChrisNeedham24
Copy link
Collaborator

Question: can you get the same achievement twice? E.g. if you get it against 2 different players?

I think it's probably not worth having it more than once, but that's just my opinion. We can gauge opinions tomorrow I suppose.

@jamesgiu
Copy link
Owner Author

jamesgiu commented Jun 24, 2021

Maybe the achievement text can record the player who was involved in triggering it

"Boar Farmer

10 game win streak against jjg"

@ChrisNeedham24
Copy link
Collaborator

Just While I'm Deploying: Play 50 games
Raise The Bat: Play 100 games
Need A Charge Code: Play 200 games

@ChrisNeedham24
Copy link
Collaborator

ChrisNeedham24 commented Jun 25, 2021

Cellar Dweller: Drop to 1100 ELO or lower ✅
Drunk On ELO: Gain 100 or more ELO in one happy hour
Mistakes Were Made: Lose 100 or more ELO in one happy hour
Shaking Hands: Win a happy hour game to 11 or more by 2 points
Who Said It Was Happy?: Lose a happy hour game to 11 or more by 2 points
A Little Embarrassing: Lose to a player with an ELO of 200+ less than you ✅
Should Have Put Money On It: Beat a player with an ELO of 200+ more than you ✅

@jamesgiu
Copy link
Owner Author

These are amazing

@ChrisNeedham24
Copy link
Collaborator

Open Season: be the victim for 5 other players
Try As You Might: be the nemesis for 5 other players

@jamesgiu
Copy link
Owner Author

Might work on this tonight

@jamesgiu jamesgiu self-assigned this Jun 27, 2021
@jamesgiu jamesgiu linked a pull request Jun 27, 2021 that will close this issue
@jamesgiu jamesgiu reopened this Jun 27, 2021
@jamesgiu
Copy link
Owner Author

First cut is in via #54

Issues:

  • match id or data (e.g. scores) isn't stored in the badge so you can't see further match details
  • since it checks your achievements upon each new entered match, if you have a huge backlog of matches from before this update, they'll be attributed to the next match you play, rather than the historical match

@ChrisNeedham24
Copy link
Collaborator

ChrisNeedham24 commented Jun 28, 2021

We may have some issues here, at least a couple of these achievements are being granted without having actually achieved them. Namely Cellar Dweller and Helpless.

@jamesgiu
Copy link
Owner Author

Yeah something weird is going on - will have a look tonight if I can (the code where they live is pretty nice to expand on though if you felt like taking a squizz too)

@ChrisNeedham24
Copy link
Collaborator

Well, the issue for Cellar Dweller is that is it's checking for an ELO of >= 1100, when it should be <= 1100. I believe the issues with the other achievements could be to do with your use of == rather than === for comparisons.

@jamesgiu
Copy link
Owner Author

#latenightcommits hahah

@jamesgiu
Copy link
Owner Author

jamesgiu commented Jun 28, 2021

I'll try and sort those out tonight, also thanks for ticking off those ideas!

EDIT: TICKING OFF I have no clue where "fucking off" came from, WTF

@jamesgiu
Copy link
Owner Author

I have no idea how that last comment had "fucking off" instead of "ticking off" - I had to do like 3 takes of it to believe it. Jesus

@ChrisNeedham24
Copy link
Collaborator

Imma be honest, I was a little confused too lol

@jamesgiu
Copy link
Owner Author

Bloody hell - table tennis is serious business

@jamesgiu
Copy link
Owner Author

jamesgiu commented Jun 28, 2021

Horatio: Play 20 games or more and have a winrate >= 80%

Getting Better (Can't Get No Worse): Play 20 games or more and have a winrate <= 40%

@ChrisNeedham24
Copy link
Collaborator

Spread the love: beat every other active player
ELO booster: lose to every other active player

@jamesgiu jamesgiu removed their assignment Nov 1, 2021
@ChrisNeedham24
Copy link
Collaborator

Was going to take a look at this but decided it was all too hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend enhancement New feature or request UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants