Remove gdim from basix.ufl.element (#65)

* Fixes related to FEniCS/basix#772

Author: jorgensd

src/adios4dolfinx/checkpointing.py

@@ -497,7 +497,6 @@ def read_mesh(
         degree,
         basix.LagrangeVariant(int(lvar)),
         shape=(mesh_geometry.shape[1],),
-        gdim=mesh_geometry.shape[1],
         dtype=mesh_geometry.dtype,
     )
     domain = ufl.Mesh(element)

src/adios4dolfinx/legacy_readers.py

@@ -316,7 +316,6 @@ def read_mesh_from_legacy_h5(
         1,
         basix.LagrangeVariant.equispaced,
         shape=(mesh_geometry.shape[1],),
-        gdim=mesh_geometry.shape[1],
     )
     domain = ufl.Mesh(element)
     return dolfinx.mesh.create_mesh(

tests/test_checkpointing.py

@@ -46,7 +46,6 @@ def test_read_write_P_2D(read_comm, family, degree, complex, mesh_2D):
                            mesh.ufl_cell().cellname(),
                            degree,
                            basix.LagrangeVariant.gll_warped,
-                           gdim=mesh.geometry.dim,
                            shape=(mesh.geometry.dim, ),
                            dtype=mesh.geometry.x.dtype)
 
@@ -72,7 +71,6 @@ def test_read_write_P_3D(read_comm, family, degree, complex, mesh_3D):
                            mesh.ufl_cell().cellname(),
                            degree,
                            basix.LagrangeVariant.gll_warped,
-                           gdim=mesh.geometry.dim,
                            shape=(mesh.geometry.dim, ))
 
     def f(x):
@@ -100,7 +98,6 @@ def test_read_write_P_2D_time(read_comm, family, degree, complex, mesh_2D):
                            mesh.ufl_cell().cellname(),
                            degree,
                            basix.LagrangeVariant.gll_warped,
-                           gdim=mesh.geometry.dim,
                            shape=(mesh.geometry.dim, ),
                            dtype=mesh.geometry.x.dtype)
 
@@ -134,7 +131,6 @@ def test_read_write_P_3D_time(read_comm, family, degree, complex, mesh_3D):
                            mesh.ufl_cell().cellname(),
                            degree,
                            basix.LagrangeVariant.gll_warped,
-                           gdim=mesh.geometry.dim,
                            shape=(mesh.geometry.dim, ))
 
     def f(x):

tests/test_checkpointing_vector.py

@@ -58,8 +58,7 @@ def test_read_write_2D(read_comm, family, degree, complex, simplex_mesh_2D):
     f_dtype = get_dtype(mesh.geometry.x.dtype, complex)
     el = basix.ufl.element(family,
                            mesh.ufl_cell().cellname(),
-                           degree,
-                           gdim=mesh.geometry.dim)
+                           degree)
 
     def f(x):
         values = np.empty((2, x.shape[1]), dtype=f_dtype)
@@ -81,8 +80,7 @@ def test_read_write_3D(read_comm, family, degree, complex, simplex_mesh_3D):
     f_dtype = get_dtype(mesh.geometry.x.dtype, complex)
     el = basix.ufl.element(family,
                            mesh.ufl_cell().cellname(),
-                           degree,
-                           gdim=mesh.geometry.dim)
+                           degree)
 
     def f(x):
         values = np.empty((3, x.shape[1]), dtype=f_dtype)
@@ -104,8 +102,7 @@ def test_read_write_2D_quad(read_comm, family, degree, complex, non_simplex_mesh
     f_dtype = get_dtype(mesh.geometry.x.dtype, complex)
     el = basix.ufl.element(family,
                            mesh.ufl_cell().cellname(),
-                           degree,
-                           gdim=mesh.geometry.dim)
+                           degree)
 
     def f(x):
         values = np.empty((2, x.shape[1]), dtype=f_dtype)
@@ -127,8 +124,7 @@ def test_read_write_hex(read_comm, family, degree, complex, non_simplex_mesh_3D)
     f_dtype = get_dtype(mesh.geometry.x.dtype, complex)
     el = basix.ufl.element(family,
                            mesh.ufl_cell().cellname(),
-                           degree,
-                           gdim=mesh.geometry.dim)
+                           degree)
 
     def f(x):
         values = np.empty((3, x.shape[1]), dtype=f_dtype)
@@ -151,8 +147,7 @@ def test_read_write_multiple(read_comm, family, degree, complex, non_simplex_mes
     f_dtype = get_dtype(mesh.geometry.x.dtype, complex)
     el = basix.ufl.element(family,
                            mesh.ufl_cell().cellname(),
-                           degree,
-                           gdim=mesh.geometry.dim)
+                           degree)
 
     def f(x):
         values = np.empty((2, x.shape[1]), dtype=f_dtype)

tests/test_numpy_vectorization.py

@@ -82,8 +82,7 @@ def test_unroll_P(family, degree, mesh_2D):
 def test_unroll_RTCF(family, degree, mesh_3D):
     el = basix.ufl.element(family,
                            mesh_3D.ufl_cell().cellname(),
-                           degree,
-                           gdim=mesh_3D.geometry.dim)
+                           degree)
 
     V = dolfinx.fem.functionspace(mesh_3D, el)
     dofmap = V.dofmap
@@ -105,8 +104,7 @@ def test_unroll_RTCF(family, degree, mesh_3D):
 def test_compute_dofmap_pos_RTCF(family, degree, mesh_3D):
     el = basix.ufl.element(family,
                            mesh_3D.ufl_cell().cellname(),
-                           degree,
-                           gdim=mesh_3D.geometry.dim)
+                           degree)
 
     V = dolfinx.fem.functionspace(mesh_3D, el)
     local_cells, local_pos = compute_dofmap_pos(V)
@@ -123,8 +121,7 @@ def test_compute_dofmap_pos_RTCF(family, degree, mesh_3D):
 def test_compute_dofmap_pos_P(family, degree, mesh_2D):
     el = basix.ufl.element(family,
                            mesh_2D.ufl_cell().cellname(),
-                           degree,
-                           gdim=mesh_2D.geometry.dim)
+                           degree)
 
     V = dolfinx.fem.functionspace(mesh_2D, el)
     local_cells, local_pos = compute_dofmap_pos(V)