Skip to content

useSTD3ASCIIRules does not work in v5.1.0 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yandrushchak opened this issue Apr 7, 2025 · 2 comments
Closed

useSTD3ASCIIRules does not work in v5.1.0 #69

yandrushchak opened this issue Apr 7, 2025 · 2 comments

Comments

@yandrushchak
Copy link
Contributor

Changes to useSTD3ASCIIRules handling in a recent commit broke the logic.
Reason - used regexp will only match 3-character strings, that start with letter, continue with digit, and end with hyphen, which can never happen. It should probably be changed to something like this: /^([a-z]|[0-9]|-)$/u

@domenic
Copy link
Member

domenic commented Apr 8, 2025

Thanks. It's unfortunate that these options don't all have sufficient test coverage.

A PR fixing this and adding such test coverage (in a new test file, I guess) would be welcome.

@yandrushchak
Copy link
Contributor Author

@domenic
Created a PR to fix this, and added a new test suite to cover this option - #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants