Skip to content

Source multiplication #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahotilo opened this issue Nov 13, 2019 · 8 comments
Open

Source multiplication #6

mahotilo opened this issue Nov 13, 2019 · 8 comments

Comments

@mahotilo
Copy link
Contributor

When I played with the video options, I sometimes noticed a doubling, tripling,.. of the video source.

Like this
src="https://www.youtube.com/embed/LMgGK47pgQ,LMgGK47pgQ?.....

@juek
Copy link
Owner

juek commented Nov 13, 2019

with commas in between? What a naughty script, isn't it?

@juek
Copy link
Owner

juek commented Nov 13, 2019

… hmm, I can recall that I added that - we can actually play several comma separated videos w/o having a playlist. Of course playing the same video several times is just stupid.
If I gonna find that bug? o_O

@juek
Copy link
Owner

juek commented Nov 13, 2019

I can't reproduce it at the moment. Must have sth. to do with the stuff around line 974. The comment says it all :-)

@mahotilo
Copy link
Contributor Author

mahotilo commented Nov 13, 2019

You didn't use Youtube API previously. Now we have the YT instances for all the videos. So, we can make loop through JS, like here
https://stackoverflow.com/questions/19410789/youtube-player-api-with-loop

onStateChange: 
    function(e) {
        if (e.data === YT.PlayerState.ENDED) {
            player.playVideo(); 
        }
    }

Can it be a solution?

@juek
Copy link
Owner

juek commented Nov 13, 2019

Can it be a solution?

For the current issue? Don't think so.
The bug is buried somewhere in the editor, which tries to satisfy this (idiotic) API with all it's value interdependencies.

@mahotilo
Copy link
Contributor Author

I mean, maybe it is easy to remove this workaround

// loop for single videos also requires playlist=video_ID (crazy hackish weird API)

and use JS solution to loop single file?

@mahotilo
Copy link
Contributor Author

Ok. This may wait a while. TS core is more important!

@mahotilo
Copy link
Contributor Author

mahotilo commented Nov 13, 2019

I found the point of a video source doubling. One problem, I can't understand what these lines are for?
911

To reproduce.
-Press "Edit Embed Code"
-Press "Apply"
(section editor input "Video" value doubles)
-Change e.g. "loop"
-Duplicated video name is in frame!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants