Skip to content
This repository was archived by the owner on Oct 28, 2022. It is now read-only.

Add support for NetBox target discovery #525

Open
karimra opened this issue Feb 2, 2022 · 2 comments
Open

Add support for NetBox target discovery #525

karimra opened this issue Feb 2, 2022 · 2 comments
Labels
enhancement New feature or request hackathon NANOG84 hackathon

Comments

@karimra
Copy link
Owner

karimra commented Feb 2, 2022

No description provided.

@karimra karimra added enhancement New feature or request hackathon NANOG84 hackathon labels Feb 2, 2022
@melkypie
Copy link
Contributor

melkypie commented Feb 8, 2022

Rather than adding Netbox target discovery it would be best for HTTP target discovery to support Prometheus format input. This would allow to use existing APIs made for Prometheus for gnmic. In the case of Netbox, one is already made: https://github.com/FlxPeters/netbox-plugin-prometheus-sd. Also file target discovery could be changed to support Prometheus format discovery as well.
Most likely best option is to just add an option in the config, where you can switch between Prometheus format or regular gnmic.

@karimra
Copy link
Owner Author

karimra commented Feb 8, 2022

This is a good idea, I wasn't aware of the prometheus NetBox plugin.

It can be achieved by adding an optional template transformation to both HTTP and File target discovery.
Netbox (or any other source producing Prometheus http_sd format) --> Prometheus Format --> Template --> gNMIc Format.

But I think it still makes sense to add a separate NetBox target discovery mechanism using its native API.

I will add a separate issue for tracking the template/Prometheus http_sd format for HTTP and File target discovery.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request hackathon NANOG84 hackathon
Projects
None yet
Development

No branches or pull requests

2 participants