Skip to content

[Bug]: Deploy action does not recognize Bank Deposits Extension #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StefanMaron opened this issue Mar 26, 2025 · 11 comments · Fixed by #1653
Closed

[Bug]: Deploy action does not recognize Bank Deposits Extension #1540

StefanMaron opened this issue Mar 26, 2025 · 11 comments · Fixed by #1653
Assignees
Labels
bug Something isn't working Fix Ready Fix Ready

Comments

@StefanMaron
Copy link

AL-Go version

6.4

Describe the issue

For some reason the deploy step tries to deploy the bank deposits app since it thinks its missing. But I have downloaded symbols with vs code from the very same environment just moments before.

Image

Expected behavior

Should not try to deploy existing apps, and also not try to deploy symbols only .app files

Steps to reproduce

Not sure how.

Additional context (logs, screenshots, etc.)

No response

@StefanMaron StefanMaron added the bug Something isn't working label Mar 26, 2025
@freddydk
Copy link
Contributor

Could you include or email me the full log in .txt format - it is hard to see anything from a screenshot
Thanks

@freddydk freddydk self-assigned this Mar 27, 2025
@StefanMaron
Copy link
Author

@freddydk Mail sent

@StefanMaron
Copy link
Author

@freddydk any updates on this one? Its blocking my client right now.

@freddydk
Copy link
Contributor

freddydk commented Apr 9, 2025

Sry - you say that it doesn't recognize Bank Deposits Extension - but the error you get is:

Deploying to DEV failed. Response status code does not indicate success: 401 (Unauthorized). Response status code does not indicate success: 401 (Unauthorized).

That looks like a different problem????

It looks like it installs Bank Deposits Extension from AppSource and then runs into an error like your S2S user doesn't have the right permissions or like?

@freddydk
Copy link
Contributor

freddydk commented Apr 9, 2025

BTW - I think the logic on Deployment here was updated after v6.4 - could you also make sure that you use the latest version?

@StefanMaron
Copy link
Author

Same issue on v7.0

Image

But it should never try to install that app from appsource because it is installed since I can download the symbols for that app from the exact same environment.

Maybe its two separate issues. But the for me important one, that it should not try to install.
I never had/have issues with installation of my apps so far using those credentials, so permission wise it should be fine.

@freddydk
Copy link
Contributor

freddydk commented Apr 9, 2025

Yeah, issue #1649 seems to be the exact same issue with a different app - I hop @spetersenms can look into this - else I will try to repro when I get back from the US.

@spetersenms
Copy link
Contributor

I can't repro the issue, but looking at the error from this and the related issue, it definitely seems related to the exclude apps. I have a potential fix ready, but will need to test further Monday before deploying it.

@StefanMaron
Copy link
Author

@spetersenms If I should test your fix on my pipeline, just let me know

@freddydk
Copy link
Contributor

@StefanMaron - feel free to try out freddydk/AL-GO@issue1540
(Run update AL-Go System files with this string - you don't need https://github.com/ in front).

You can always switch back if this doesn't work.

@StefanMaron
Copy link
Author

@freddydk it works now on your version.

@freddydk freddydk added the Fix Ready Fix Ready label Apr 13, 2025
freddydk added a commit that referenced this issue Apr 14, 2025
Issue 1540 and 1649 apps with dependencies to Microsft__EXCLUDE_ apps
fails deployment

Fixes #1540
Fixes #1649

---------

Co-authored-by: freddydk <freddydk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fix Ready Fix Ready
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants