Skip to content

MKC Does Not Re-Read mkc.Json After the First Time #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aznhassan opened this issue Mar 30, 2023 · 0 comments
Open

MKC Does Not Re-Read mkc.Json After the First Time #109

aznhassan opened this issue Mar 30, 2023 · 0 comments
Assignees

Comments

@aznhassan
Copy link
Contributor

Problem

The Project class in mkc.ts will not re-read mkc.json after it loads the first time. Even if the targetwebsite changes, it'll still build with the old version.

Repro

To repro do the following:

  • In an empty folder run mkc init arcade
  • Change targetWebsite iin mkc.json to https://arcade.makecode.com/v1.12.22
  • Run mkc build -j -w to build and start a watch
  • Notice the build runs with v1.12.22
  • Change the patch version in mkc.json to 23
  • Notice the build runs with v1.12.22 again

You can keep changing the version and it will never change.

Notes

Start looking at loadPkgAsync for a possible solution.

async loadPkgAsync() {
if (this.mainPkg) return
const prj = await this.readPackageAsync()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants