You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1775: Backport fixes for release/2.7 r=tiagolobocastro a=tiagolobocastro
test(bdd): make nvme controller usage more robust
Caters for when the device is /dev/nvmeX but X not the same as the controller!
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
Merge #1755
1755: Reuse Rebuild IO handles r=tiagolobocastro a=tiagolobocastro
fix(rebuild): reuse rebuild IO handles
Reuses the rebuild IO handles, rather than attempting to allocate
them per rebuild task.
The main issue with handle allocation on the fly is that the target
may have not cleaned up a previous IO qpair connection, and so the
connect may fail. We started seeing this more on CI because we forgot
to cherry-pick a commit increasing the retry delay.
However, after inspecting a bunch of user support bundles I see that
we still have occasional connect errors. Rather than increasing the
timeout, we attempt here to reuse the handles, thus avoid the
problem almost entirely.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
refactor(rebuild): rebuild completion is not an error
When the rebuild has been complete, if we wait for it this fails because
the channels are not longer available.
Instead, simply return the rebuild state, since this is what we want anyway.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
---
fix: check valid sct and sc combinations for pi error
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
---
fix: use auto-detected sector size for blockdev
This fixes the behaviour where we pass 512 as sector size if the
disk uri doesn't contain blk_size parameter. This causes pool creation
failure if the underlying disk has a different sector size e.g. 4096.
Instead of passing 512, we now pass 0 which lets spdk detect the
device's sector size and use that value.
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
Co-authored-by: Diwakar Sharma <diwakar.sharma@datacore.com>
Co-authored-by: mayastor-bors <mayastor-bors@noreply.github.com>
Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
0 commit comments