chore: address review comments

Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>

Author: dsharma-dc

io-engine/src/lvs/lvs_error.rs

@@ -49,8 +49,8 @@ pub enum BsError {
     OutOfMetadata {},
     #[snafu(display(": capacity overflow"))]
     CapacityOverflow {},
-    #[snafu(display(": crypto vbdev error"))]
-    LvsCryptoVbdev {},
+    #[snafu(display(": crypto vbdev error. {source:?}"))]
+    LvsCryptoVbdev { source: Errno },
 }
 
 impl BsError {
@@ -103,7 +103,7 @@ impl ToErrno for BsError {
             Self::NoSpace {} => Errno::ENOSPC,
             Self::OutOfMetadata {} => Errno::EMFILE,
             Self::CapacityOverflow {} => Errno::EOVERFLOW,
-            Self::LvsCryptoVbdev {} => Errno::EINVAL,
+            Self::LvsCryptoVbdev { source } => source,
         }
     }
 }

io-engine/src/lvs/lvs_store.rs

@@ -364,14 +364,19 @@ impl Lvs {
                 if let Some(e) = args.enc_key {
                     match create_crypto_vbdev_on_base_bdev(cname, &bdev, &e) {
                         Ok(_) => {}
-                        Err(_) => {
-                            let _ = parsed.destroy().await.map_err(|_e| {
+                        Err(berr) => {
+                            let _ = parsed.destroy().await.map_err(|e| {
                                     error!(
-                                        "failed to delete base_bdev {bdev} after failed crypto vbdev creation"
+                                        "failed to delete base_bdev {bdev} after failed crypto vbdev creation. {e:?}"
                                     );
                                 });
                             return Err(LvsError::PoolCreate {
-                                source: BsError::LvsCryptoVbdev {},
+                                source: BsError::LvsCryptoVbdev {
+                                    source: match berr {
+                                        BdevError::CreateBdevFailed { source, .. } => source,
+                                        _ => Errno::EINVAL,
+                                    },
+                                },
                                 name: args.name.clone(),
                             });
                         }
@@ -588,14 +593,19 @@ impl Lvs {
             if let Some(ref e) = args.enc_key {
                 match create_crypto_vbdev_on_base_bdev(cname, &bdev_name, e) {
                     Ok(_) => {}
-                    Err(_) => {
-                        let _ = bdev_ops.destroy().await.map_err(|_e| {
+                    Err(berr) => {
+                        let _ = bdev_ops.destroy().await.map_err(|e| {
                                 error!(
-                                    "failed to delete base_bdev {bdev_name} after failed crypto vbdev creation"
+                                    "failed to delete base_bdev {bdev_name} after failed crypto vbdev creation. {e:?}"
                                 );
                             });
                         return Err(LvsError::PoolCreate {
-                            source: BsError::LvsCryptoVbdev {},
+                            source: BsError::LvsCryptoVbdev {
+                                source: match berr {
+                                    BdevError::CreateBdevFailed { source, .. } => source,
+                                    _ => Errno::EINVAL,
+                                },
+                            },
                             name: args.name.clone(),
                         });
                     }