Skip to content

Refactor: Course state file should contain path as id and not indexes #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuelroland opened this issue Sep 3, 2024 · 0 comments
Labels
p3 Priority 3

Comments

@samuelroland
Copy link
Collaborator

Currently, the .course-state.toml at repos root is serialized with the given fields. The problem is that using indexes might cause issues when new exos or skills are created, therefore shifting the indexes... When resuming an exo it might jump to an older exo.

pub(crate) curr_skill_idx: usize,
pub(crate) curr_exo_idx: usize,

A more stable identifier would be to store the path.

@samuelroland samuelroland added p3 Priority 3 and removed post-pdg labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 Priority 3
Projects
None yet
Development

No branches or pull requests

1 participant