Skip to content

Commit 7bd9ed6

Browse files
authored
Allow public clients without secrets (#19)
1 parent 7dcfdcd commit 7bd9ed6

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

controllers/cluster_controller.go

+6-5
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,12 @@ func (r *ClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (re
154154
}
155155

156156
// Vault secret
157-
if client.Secret == nil || *client.Secret == "" {
158-
return ctrl.Result{}, fmt.Errorf("client %q has no secret", *templatedClient.ClientID)
159-
}
160-
if err := r.syncVaultSecret(ctx, instance, *client.Secret); err != nil {
161-
return ctrl.Result{}, fmt.Errorf("unable to sync vault secret: %w", err)
157+
if client.Secret != nil && *client.Secret != "" {
158+
if err := r.syncVaultSecret(ctx, instance, *client.Secret); err != nil {
159+
return ctrl.Result{}, fmt.Errorf("unable to sync vault secret: %w", err)
160+
}
161+
} else {
162+
l.Info("Client has no secret, might be a public client. Skipping vault secret sync.")
162163
}
163164

164165
// template client roles

0 commit comments

Comments
 (0)