Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Improve Accordion example for docs #1027

Open
kotAPI opened this issue Apr 5, 2025 · 4 comments
Open

[New Feature] Improve Accordion example for docs #1027

kotAPI opened this issue Apr 5, 2025 · 4 comments

Comments

@kotAPI
Copy link
Collaborator

kotAPI commented Apr 5, 2025

🚀 Feature Request


Feature Description

Accordion docs are currently using AccordionItem's value prop with item+index to generate a string, use ids for these, since we already have an array, we can add id's for each array and pass that as a value instead

Link : https://www.rad-ui.com/docs/components/accordion

Image
@romeu-maleiane
Copy link

Hi, I would like to contrinute to this issue improving the Accordion example as suggested.
Would it be okay for me to take this on?

@kotAPI
Copy link
Collaborator Author

kotAPI commented Apr 5, 2025

Hi, I would like to contrinute to this issue improving the Accordion example as suggested.
Would it be okay for me to take this on?

Hey, sure, please go ahead

@romeu-maleiane
Copy link

I'm preparing a PR to this issue and i see that Accordion.Trigger and Accordion.Content receive index as a prop. I want to know if is safe to remove it from the example?

@kotAPI
Copy link
Collaborator Author

kotAPI commented Apr 5, 2025

I'm preparing a PR to this issue and i see that Accordion.Trigger and Accordion.Content receive index as a prop. I want to know if is safe to remove it from the example?

Yup we can remove that, thanks for bringing it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants