Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nats_jetstream output does not detect disconnect #3257

Open
njkleiner opened this issue Mar 11, 2025 · 0 comments
Open

nats_jetstream output does not detect disconnect #3257

njkleiner opened this issue Mar 11, 2025 · 0 comments
Labels
bug nats Issues relating to NATS and Jetstream needs investigation It looks as though have all the information needed but investigation is required

Comments

@njkleiner
Copy link

The nats_jetstream output does not appear to implement logic for detecting that a message publishing failure is caused by the connection to the NATS server having been lost. Consequently, according to the Prometheus metrics and the /ready health check endpoint, the output continues to appear as "up", which is clearly wrong.

From taking a quick look at the code, it would appear that fixing this is as simple as inspecting the error returned here after a message could not be published and conditionally returning service.ErrNotConnected.

Note that the nats output already appears to implement this logic, so I'm assuming this is simply an oversight and not intended behavior.

@mihaitodor mihaitodor added bug needs investigation It looks as though have all the information needed but investigation is required nats Issues relating to NATS and Jetstream labels Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug nats Issues relating to NATS and Jetstream needs investigation It looks as though have all the information needed but investigation is required
Projects
None yet
Development

No branches or pull requests

2 participants