Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientbound/minecraft:system_chat #1130

Open
AxDevv opened this issue Feb 1, 2025 · 8 comments
Open

clientbound/minecraft:system_chat #1130

AxDevv opened this issue Feb 1, 2025 · 8 comments
Labels
bug Something isn't working

Comments

@AxDevv
Copy link

AxDevv commented Feb 1, 2025

Describe the bug
https://pastebin.com/DsSzjR02

Software brand
5.4.0-SNAPSHOT-739
packetevent 2.7.1+2a137b005-SNAPSHOT

How To Reproduce
I use the plugin TypeWriter

@AxDevv AxDevv added the bug Something isn't working label Feb 1, 2025
@Toshiii35
Copy link

Experiencing the same issue, the "dialogue" box from typewriter wouldn't exit and just stays in the chat, sending that error message

@booky10
Copy link
Collaborator

booky10 commented Feb 28, 2025

could you please provide a clear way to reproduce this issue?

@Toshiii35
Copy link

could you please provide a clear way to reproduce this issue?

Hey! This happens with typewriter plugin, usually happens (at least in my case) when a dialogue goes in the chat and there are "options" you need to select and when you choose one, the dialogue SHOULD go out/be cleared, but it doesn't and sends this error instead.

@gabber235
Copy link
Contributor

@booky10, author of Typewriter here 👋. I've seen this issue come up multiple times.

For most users, it is likely that another plugin is sending messages with the show_item hover component type.

This error occurs because Typewriter listens for system chat packets and attempts to read their content.

Caused by: java.lang.IllegalArgumentException: There is no data holder converter registered to convert from a class com.github.retrooper.packetevents.util.adventure.AdventureNBTSerializer$NbtComponentValue instance to a class io.papermc.paper.adventure.PaperAdventure$DataComponentValueImpl (on field minecraft:lore)

I don't think this is something I can change myself; it needs to be fixed in packetevents.

@booky10
Copy link
Collaborator

booky10 commented Mar 16, 2025

packetevents reads and writes components from/to serialized nbt, so im not how this class cast exception happens

I didn't do much investigation on this issue yet - do you happen to send components read via packetevents through the paper api?
this would probably cause this error, as paper expects their own show_item classes and casts to them
@gabber235

@gabber235
Copy link
Contributor

Typewriter is not the plugin sending the messages. We have a PacketListener that monitors system messages. It intercepts packets and reads their contents using the corresponding wrapper, and this process causes the exception.

Someone on the Typewriter Discord mentioned that Triton might be the cause. I have not verified this myself, but it might give you a lead.

@Toshiii35
Copy link

I can say that it's not because of Triton because I have no idea about it since I don't use/have it.

@Ferxs09
Copy link

Ferxs09 commented Mar 19, 2025

I use the triton plugin which is a message translation plugin, I removed all the plugins from my server, added the typewriter and its dependencies, and to test why it was failing I first added Triton, as soon as I added it, the dialog messages stopped appearing and I got an error with the chat management, now I removed that plugin and it works fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants