Activate 'check_untyped_defs' and 'disallow_untyped_defs' mypy checks on ffcx.*

Author: schnellerhase

ffcx/compiler.py

@@ -79,7 +79,7 @@
 logger = logging.getLogger("ffcx")
 
 
-def _print_timing(stage: int, timing: float):
+def _print_timing(stage: int, timing: float) -> None:
     logger.info(f"Compiler stage {stage} finished in {timing:.4f} seconds.")
 
 

ffcx/formatting.py

@@ -38,13 +38,13 @@ def format_code(code: CodeBlocks) -> tuple[str, str]:
     return code_h, code_c
 
 
-def write_code(code_h, code_c, prefix, output_dir):
+def write_code(code_h: str, code_c: str, prefix: str, output_dir: str) -> None:
     """Write code to files."""
     _write_file(code_h, prefix, ".h", output_dir)
     _write_file(code_c, prefix, ".c", output_dir)
 
 
-def _write_file(output, prefix, postfix, output_dir):
+def _write_file(output: str, prefix: str, postfix: str, output_dir: str) -> None:
     """Write generated code to file."""
     filename = os.path.join(output_dir, prefix + postfix)
     with open(filename, "w") as hfile:

ffcx/main.py

@@ -14,6 +14,8 @@
 import pathlib
 import re
 import string
+from collections.abc import Sequence
+from typing import Optional
 
 import ufl
 
@@ -45,7 +47,7 @@
 parser.add_argument("ufl_file", nargs="+", help="UFL file(s) to be compiled")
 
 
-def main(args=None):
+def main(args: Optional[Sequence[str]] = None) -> int:
     """Run ffcx on a UFL file."""
     xargs = parser.parse_args(args)
 

pyproject.toml

@@ -79,9 +79,12 @@ ignore_missing_imports = true
 
 [[tool.mypy.overrides]]
 module = ["ffcx.*", "ffcx.ir.*", "ffcx.codegeneration.*"]
-disallow_untyped_defs = false
-disallow_any_unimported = false
+disallow_any_unimported = false # most of these come from UFL
+
+[[tool.mypy.overrides]]
+module = ["ffcx.ir.*", "ffcx.codegeneration.*"]
 check_untyped_defs = false
+disallow_untyped_defs = false 
 
 [tool.ruff]
 line-length = 100