Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: R2D Pump Lockout #238

Open
3 tasks done
Avdieienko opened this issue Sep 19, 2024 · 4 comments · May be fixed by sufst/can-defs#33
Open
3 tasks done

feat: R2D Pump Lockout #238

Avdieienko opened this issue Sep 19, 2024 · 4 comments · May be fixed by sufst/can-defs#33
Assignees
@r-kirkbride
Labels
feature New features good first issue Good for newcomers Priority Needs to be done for Comp
Milestone
STAG 11

Comments

@Avdieienko
Copy link
Member

Avdieienko commented Sep 19, 2024 •
edited by r-kirkbride
Loading

Description

Check for pump load through PDM before getting into R2D. This is needed to make sure that pumps actually work before proceeding.

Requirements

  • Start pumps before entering r2d
  • Check if their voltage is high enough to classify as "working"
  • Block entering r2d if not
@Avdieienko Avdieienko added the feature New features label Sep 19, 2024
@Avdieienko Avdieienko added this to the STAG 11 milestone Sep 19, 2024
@Avdieienko
Copy link
Member Author

Read the CAN-S message PDM_Out_Voltage to determine the load on the pumps. Pump1 corresponds to pin 4, and Pump2 corresponds to pin 5.

@Avdieienko Avdieienko added the good first issue Good for newcomers label Nov 29, 2024
@r-kirkbride
Copy link

r-kirkbride commented Dec 10, 2024 •
edited
Loading

Note to self:
Need to read PDM_Output_4_Voltage & PDM_Output_5_Voltage
See pm100.c

@r-kirkbride r-kirkbride self-assigned this Dec 10, 2024
@D4nDude D4nDude added the Priority Needs to be done for Comp label Jan 28, 2025
@r-kirkbride
Copy link

Voltage should be 12V to classify as working?

@Avdieienko
Copy link
Member Author

@r-kirkbride let it be anything over 8V

@r-kirkbride r-kirkbride linked a pull request Feb 25, 2025 that will close this issue
Feat/r2d pump lockout sufst/can-defs#33
Open
2 tasks
This was referenced Feb 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-kirkbride r-kirkbride

Labels
feature New features good first issue Good for newcomers Priority Needs to be done for Comp
Projects
None yet
Milestone
STAG 11
Development

Successfully merging a pull request may close this issue.

feat/r2d-pump-lockout sufst/vcu
Feat/r2d pump lockout sufst/can-defs
3 participants
@D4nDude @Avdieienko @r-kirkbride