NEWS and CRAN comments [ci skip]

Author: krlmlr

NEWS.md

@@ -13,6 +13,15 @@
 ## Features
 
 - Only allow constants in `mutate()` that are actually representable in duckdb (#73).
+- Avoid translating `ifelse()`, support `if_else()` (#79).
+
+## Documentation
+
+- Separate and explain the new relational examples (@wibeasley, #84).
+
+## Testing
+
+- Add test that TPC-H queries can be processed.
 
 ## Chore
 
@@ -22,23 +31,10 @@
 - Fix code generated by `meta_replay()`.
 - Bump constructive dependency.
 - Fix output order for `arrange()` in case of ties.
-- Full sync.
 - Update duckdb tests.
 - Only implement newer `slice_sample()`, not `sample_n()` or `sample_frac()` (#74).
 - Sync generated files (#71).
 
-## Documentation
-
-- Separate and explain the new relational examples (@wibeasley, #84).
-
-## Testing
-
-- Add test that TPC-H queries can be processed; feat: Avoid translating `ifelse()`, support `if_else()` (#79).
-
-## Uncategorized
-
-- Merge branch 'cran-0.2.3'.
-
 
 # duckplyr 0.2.3 (2023-11-08)
 

cran-comments.md

@@ -9,24 +9,11 @@ duckplyr 0.3.0
 ## Current CRAN check results
 
 - [x] Checked on 2023-12-10, problems found: https://cran.r-project.org/web/checks/check_results_duckplyr.html
-- [ ] other_issue: NA
+- [x] other_issue: fixed
 See: <https://www.stats.ox.ac.uk/pub/bdr/gcc12/duckplyr.out>
-- [ ] other_issue: NA
-See: <https://www.stats.ox.ac.uk/pub/bdr/gcc12/duckplyr.out>
-- [ ] WARN: r-devel-linux-x86_64-debian-gcc
+- [x] WARN: r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64
      Found the following significant warnings:
      relational.c:35:27: warning: format ‘%p’ expects argument of type ‘void *’, but argument 2 has type ‘SEXP’ {aka ‘struct SEXPREC *’} [-Wformat=]
      See ‘/home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/duckplyr.Rcheck/00install.out’ for details.
      * used C compiler: ‘gcc-13 (Debian 13.2.0-7) 13.2.0’
-- [ ] WARN: r-devel-linux-x86_64-fedora-gcc
-     Found the following significant warnings:
-     relational.c:35:27: warning: format '%p' expects argument of type 'void *', but argument 2 has type 'SEXP' {aka 'struct SEXPREC *'} [-Wformat=]
-     See ‘/data/gannet/ripley/R/packages/tests-devel/duckplyr.Rcheck/00install.out’ for details.
-     * used C compiler: ‘gcc-13 (GCC) 13.2.0’
-- [ ] WARN: r-devel-windows-x86_64
-     Found the following significant warnings:
-     relational.c:35:27: warning: format '%p' expects argument of type 'void *', but argument 2 has type 'SEXP' {aka 'struct SEXPREC *'} [-Wformat=]
-     See 'd:/Rcompile/CRANpkg/local/4.4/duckplyr.Rcheck/00install.out' for details.
-     * used C compiler: 'gcc.exe (GCC) 12.3.0'
-
-Check results at: https://cran.r-project.org/web/checks/check_results_duckplyr.html
+     Fixed.