Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release on pypi #368

Open
alexis-via opened this issue Dec 1, 2022 · 11 comments · May be fixed by #372
Open

New release on pypi #368

alexis-via opened this issue Dec 1, 2022 · 11 comments · May be fixed by #372
Milestone

Comments

@alexis-via
Copy link

I started using the "rows" lib today, and I've lost several hours of work because of a bug on empty cells in ods input. Here is my story.

I was learning/discovering the "rows" lib with an ODS file, and I fall across a strange behavior. Of course, I thought it was because I didn't use the lib properly : so I tried all possible options, searched on the Internet... etc. After several hours, I eventually tried the same code with an equivalent XLSX file and I found out that the behavior was different ! So I realized that I had found a bug on my first day of use of the rows lib !

I decided that I should report the bug. I took the time to write a script to illustrate my bug report. I was using rows 0.4.1 from pypi, but, before creating the bug report on github, I thought I should check if the bug is still present in the "develop" branch... and my script shows that the bug is fixed in the "develop" branch !

Release 0.4.1 is dated Feb 14, 2019... almost 4 years old ! There has been 210 commits since 0.4.1 ; among these 210 commits, I counted about 45 fixes. While counting the commit messages with a fix message, I found the commit that fixes my bug: issue #320 fixed on Match 27 2019 in this commit c569f94

So, in December 2022, some users are wasting hours because of a bug that was found and fixed 3,5 years ago :-( No comment !

So, please, push a new release on pypi !

@turicas
Copy link
Owner

turicas commented Dec 2, 2022

Sorry to hear you had a bad experience.
I'm working on updating the changelog so we can finally release the 0.5.0 - which will break Python 2 compatibility (I was locked by this breaking change and decided to go ahead without py2).
Hope to push to PyPI next few days. By now, you can install the current version by:

pip install https://github.com/turicas/rows/archive/develop.zip

@alexis-via
Copy link
Author

@turicas Great to hear that you're planning a new release in the short term.
I'm now running with the code from github, so it works well for me now.

@alexis-via
Copy link
Author

Any update about a new release on pypi ?

@alexis-via
Copy link
Author

So, what about the release on pypi ?

@alexis-via
Copy link
Author

Example of code that I have to write to block users using pypi for rows:
https://github.com/akretion/account-move-import/blob/16.0/account_move_csv_import/wizard/account_move_import.py#L477

@a-detiste
Copy link

a-detiste commented Feb 11, 2024

break Python 2 compatibility

I had to add weird patches to Debian vendoring some parts of old unicodecsv, I'd like to clean this up some day.

@alexis-via
Copy link
Author

@turicas Do you still plan to make a release on pypi some day, or did you choose to continue without releasing on pypi ?

@alexis-via
Copy link
Author

alexis-via commented Jan 2, 2025

As new year resolution for 2025, I propose "make a new release on pypi" :)

@turicas
Copy link
Owner

turicas commented Mar 21, 2025

Hello, @alexis-via. Challenge accepted! o/

Sorry for this long delay. I've been adding lots of new features to the develop branch in the last years but couldn't "just" make a new release to PyPI since the tests were not passing on all currently supported Python versions.

Now it's time to clean up everything, make a proper release deprecating these Python versions so I can move with the development without all this burden. I'm working on this on #372 and you can check more details there. I needed to create my own Python docker images to properly run tests on older versions and now almost all tests are fixed. Still have some work to do, but most of it was already done. In this cleanup I already removed unicodecsv and other dependencies (which will make not only easier to maintain but execute faster also).
Please help voting at the poll #373 regarding Python versions you're using so I can define the deprecated ones.

@turicas turicas linked a pull request Mar 21, 2025 that will close this issue
@alexis-via
Copy link
Author

Great news, thanks ! I voted on the poll for the python version. I mostly use Ubuntu 22.04 on the servers of my customers, so it runs python 3.10.

@turicas turicas added this to the Version 0.5.0 milestone Mar 21, 2025
@jsbueno
Copy link
Collaborator

jsbueno commented Apr 4, 2025

So, while we are it, some people might be happy to know that "uv" can just run rows as is, if one uses the git url, and tells it to use the [cli] extras:, no explicit install needed:

$ uvx --from https://github.com/turicas/rows.git[cli] rows print --frame-style single  csv.csv
┌────────┬───────┐
│  nome  │ idade │
├────────┼───────┤
│ Daniel │    20 │
│   Joao │    35 │
└────────┴───────┘


(Once published to pypy, uvx rows print ... should be all that is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants