Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bazel #225

Open
timofurrer opened this issue Nov 26, 2024 · 0 comments
Open

Support bazel #225

timofurrer opened this issue Nov 26, 2024 · 0 comments
Assignees
@linzhp

Comments

@timofurrer
Copy link

timofurrer commented Nov 26, 2024 •
edited
Loading

Requested feature

Support the currently deprecated gomock support in bazel/rules_go.
I learnt from bazel-contrib/rules_go#4153 (comment) that support for Bazel should eventually end up in this project.

Why the feature is needed

Helps to easily integrate gomock into a Bazel project.

(Optional) Proposed solution

See bazel-contrib/rules_go#4153
@linzhp linzhp mentioned this issue Jan 5, 2025
Merged
@linzhp linzhp self-assigned this Jan 5, 2025
linzhp added a commit that referenced this issue Feb 4, 2025
@linzhp
Copying gomock definition and tests from rules_go (#231)
bb4128e 
This PR copies the gomock definition and tests from rules_go with
minimal changes:

* Replacing github.com/golang/mock with go.uber.org/mock
* Replacing `load` statements accordingly
* Setting up a Bazel and a Go module in the "bazel" directory

Note that the Go module uses v0.4.0 of go.uber.org/mock, because the
latest version is no longer compatible with the gomock rule
(bazel-contrib/rules_go#4153). We will update
the rule and mockgen version in subsequent PRs.

This is a first step in addressing #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linzhp linzhp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linzhp @timofurrer