Soft deleting a ratelimit namespace causes an error if the same name is used again.

[perkinsjr]

Preliminary Checks

• I have reviewed the documentation: https://unkey.com/docs

• I have searched for existing issues: https://github.com/unkeyed/unkey/issues

• This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

As a user if someone deletes a namespace by accident from our ratelimit for example

user.delete

They are unable to create a new namespace with the name of user.delete when they attempt it they get:

{
    "code": "INTERNAL_SERVER_ERROR",
    "httpStatus": 500,
    "stack": "TRPCError: We are unable to create namspace. Please try again or contact support@unkey.dev\n    at (vc/edge/function:1030:252976)\n    at (vc/edge/function:1030:252400)\n    at (vc/edge/function:295:130122)\n    at (vc/edge/function:295:129531)\n    at (vc/edge/function:295:129531)\n    at (vc/edge/function:295:129531)\n    at (vc/edge/function:295:129841)\n    at (vc/edge/function:1040:13815)\n    at (vc/edge/function:1040:15263)",
    "path": "ratelimit.namespace.create"
}

We should allow recreation or allow restoration without our intervention

Steps to Reproduce

1. delete namespace
2. recreate namespace with same name
3. error

Expected behavior

Allow for the same namespace to be used again after soft delete or gracefully allow for restoration.

Other information

No response

Screenshots

No response

Version info

N/A

[linear]

ENG-1621 Soft deleting a ratelimit namespace causes an error if the same name is used again.

[harshsbhat]

Can I give it a shot? if it is not planned internally

[chronark]

@harshsbhat how do you plan to tackle it?

[harshsbhat]

@chronark

Before inserting the namespace into the database we can check if the namespace is soft deleted or not.

const isSoftDeleted = await db.query.ratelimitNamespaces
        .findFirst({
          where: (table, { and, eq }) =>
            and(eq(table.name, input.name)),
        })
});

If it is soft deleted we can simply update the table for deleted_at = null and return the id of the same namespace.

This will allow the user to restore the namespace without manual intervention.

[harshsbhat]

Also, I just checked we need to change the deleted_at = null for all the overrides as well. Let me know if this sounds a fair approach.

[harshsbhat]

@chronark I have created a draft PR. There is also a video in that PR on how I have tackled this issue.

#2872