Skip to content

Improve ignore pattern parsing by trimming whitespace after split(',') #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yamadashy opened this issue Mar 14, 2025 · 3 comments
Open

Improve ignore pattern parsing by trimming whitespace after split(',') #417

yamadashy opened this issue Mar 14, 2025 · 3 comments
Assignees
@pranshugupta01
Labels
enhancement New feature or request

Comments

@yamadashy
Copy link
Owner

yamadashy commented Mar 14, 2025 •
edited
Loading

Currently, Repomix's ignore pattern parsing does not trim whitespace after splitting on ,. This can lead to unexpected behavior, where patterns contain unintended leading spaces.

I plan to improve the parser to trim whitespace after split(',') so the first pattern style works as expected. There should be very few cases where leading or trailing spaces are actually needed in patterns, and in those rare cases, \s can be used.

related
@yamadashy yamadashy added the enhancement New feature or request label Mar 15, 2025
@pranshugupta01
Copy link
Contributor

Hey @yamadashy , i want to work on this issue, can you please assign me

@yamadashy
Copy link
Owner Author

Hi, @pranshugupta01 !
Thanks again for jumping in — really appreciate your help #452 too! I've just assigned the issue to you. Looking forward to your PR!

@pranshugupta01 pranshugupta01 mentioned this issue Apr 6, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranshugupta01 pranshugupta01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yamadashy @pranshugupta01 and others