Drop Imath2 support and modernize Imath includes #1852
Conversation
Signed-off-by: Julius Künzel <julius.kuenzel@kde.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
+ Coverage 84.11% 84.80% +0.69%
==========================================
Files 198 176 -22
Lines 22241 12745 -9496
Branches 4687 1181 -3506
==========================================
- Hits 18709 10809 -7900
+ Misses 2610 1758 -852
+ Partials 922 178 -744
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 123 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
As suggested by Imath devs, see AcademySoftwareFoundation/Imath#136 (comment) This is possible now that Imath 2 support was dropped Signed-off-by: Julius Künzel <julius.kuenzel@kde.org>
This will make it easier for downstream users Signed-off-by: Julius Künzel <julius.kuenzel@kde.org>
| "${PROJECT_SOURCE_DIR}/src/deps/rapidjson/include") | ||
|
|
||
| if(USE_DEPS_IMATH) | ||
| target_include_directories(opentimelineio PRIVATE "${PROJECT_SOURCE_DIR}/src/deps/Imath/src") |
There was a problem hiding this comment.
I know PRIVATE was from the original code, but should it be removed since Imath is part of the public API? Would that allow other targets using the opentimelineio target to pick up the Imath dependency? Like the Python bindings, tests, or if OTIO is being used as a Git sub-module.
Summarize your change.
As quickly discussed in the Slack channel...
OpenEXR developers recommend to use full namespace includes like
#include <Imath/ImathBox.h>, but we still use#include <ImathBox.h>.The support of OpenEXR/Imath 2 blocks changing the includes to full namespace. However Imath 3 has be released 4 years ago and OpenEXR/Imath 2 is no longer on the vfxplatform horizon so it seems appropriated to just remove support for it.