Skip to content

Add Status method for images client. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add Status method for images client. #7

wants to merge 2 commits into from

Conversation

AlekSi
Copy link
Owner

@AlekSi AlekSi commented Apr 4, 2019

Refs #4.

"net/http"
)

type Client struct {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type Client should have comment or be unexported (from golint)

return http.DefaultClient
}

type StatusResponse struct {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type StatusResponse should have comment or be unexported (from golint)

Used int
}

func (c *Client) Status() (*StatusResponse, error) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported method Client.Status should have comment or be unexported (from golint)

if err != nil {
return nil, err
}
defer resp.Body.Close()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value of resp.Body.Close is not checked (from errcheck)

Repository owner deleted a comment from codecov bot Apr 6, 2019
Repository owner deleted a comment from codecov bot Apr 6, 2019
Repository owner deleted a comment from codecov bot Apr 6, 2019
@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #7 into master will decrease coverage by 3.73%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   31.72%   27.98%   -3.74%     
==========================================
  Files           3        5       +2     
  Lines         186      218      +32     
==========================================
+ Hits           59       61       +2     
- Misses        120      150      +30     
  Partials        7        7
Impacted Files Coverage Δ
images/client.go 0% <0%> (ø)
speaker/effect.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23ef7b...734b83f. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #7 into master will decrease coverage by 3.73%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   31.72%   27.98%   -3.74%     
==========================================
  Files           3        5       +2     
  Lines         186      218      +32     
==========================================
+ Hits           59       61       +2     
- Misses        120      150      +30     
  Partials        7        7
Impacted Files Coverage Δ
images/client.go 0% <0%> (ø)
speaker/effect.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a15be...fa5ce80. Read the comment docs.

@AlekSi AlekSi closed this Aug 4, 2019
@AlekSi AlekSi deleted the images branch August 4, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants