-
Notifications
You must be signed in to change notification settings - Fork 0
Add Status method for images client. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"net/http" | ||
) | ||
|
||
type Client struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type Client
should have comment or be unexported (from golint
)
return http.DefaultClient | ||
} | ||
|
||
type StatusResponse struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type StatusResponse
should have comment or be unexported (from golint
)
Used int | ||
} | ||
|
||
func (c *Client) Status() (*StatusResponse, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method Client.Status
should have comment or be unexported (from golint
)
if err != nil { | ||
return nil, err | ||
} | ||
defer resp.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error return value of resp.Body.Close
is not checked (from errcheck
)
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 31.72% 27.98% -3.74%
==========================================
Files 3 5 +2
Lines 186 218 +32
==========================================
+ Hits 59 61 +2
- Misses 120 150 +30
Partials 7 7
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 31.72% 27.98% -3.74%
==========================================
Files 3 5 +2
Lines 186 218 +32
==========================================
+ Hits 59 61 +2
- Misses 120 150 +30
Partials 7 7
Continue to review full report at Codecov.
|
Refs #4.