Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job: second commit vulture fix #2205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Job: second commit vulture fix #2205

wants to merge 1 commit into from

Conversation

VindeeR
Copy link
Contributor

@VindeeR VindeeR commented Mar 11, 2025

Class job -> there would be too many changes

  • Vulture Fix

@VindeeR VindeeR added enhancement New feature or request Refactor labels Mar 11, 2025
@VindeeR VindeeR self-assigned this Mar 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.15%. Comparing base (a3e7ce5) to head (5a435f8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2205      +/-   ##
==========================================
+ Coverage   52.10%   52.15%   +0.04%     
==========================================
  Files          71       71              
  Lines       17610    17582      -28     
  Branches     3416     3412       -4     
==========================================
- Hits         9176     9170       -6     
+ Misses       7635     7614      -21     
+ Partials      799      798       -1     
Flag Coverage Δ
fast-tests 52.15% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write_total_stat_by_retries is really not used… but the other messages look a bit harder to approve without causing conflicts in other PRs. Let's hold back on this for now.

@VindeeR VindeeR force-pushed the vulture_job_job_fix branch from 07599f3 to 5a435f8 Compare March 13, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants